Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Melissa Hilliard <63749096+MelissaHilliard@users.noreply.github.com>
  • Loading branch information
chotea and MelissaHilliard authored Jun 30, 2023
1 parent c79b4fa commit a37ca3d
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions release-notes/2023-07/SystemsConnectionMigration.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,27 +10,27 @@ that would have a different public key.

1. Open a terminal to the current 'saltmaster-0' pod.
2. Navigate to '/etc/salt/pki/master'
3. Grab the master.pem (private key) and master.pub (public key) values.
3. Make a note of the master.pem (private key) and master.pub (public key) values.
4. Set these values to the secrets definition object of the saltmaster chart in the top level secrets values yaml file. Make sure
you use the '|' indicator because these are multiline strings. See more info here: <https://yaml-multiline.info/>

The updated chart will create a Kubernetes secret using these two keys.

## Post SLE Upgrade

After the upgrade, it is expected that all previously connected (green/orange systems) will be shown as **Disconnected**. In addition to that, all these clients will also be shown in the **Pending systems** list. A [Jupyter Notebook](./NewSaltMaster-SystemsMigration.ipynb) has been provided if you wish to automate system approval. This notebook will add systems to the workspace they were previously a member of. The user that will run the notebook needs to have the **Add systems** privilege in all the necessary workspaces.
After the upgrade, all previously connected (green/orange systems) will be shown as **Disconnected**. Additionally, all these clients will also be shown in the **Pending systems** list. You can use the [Jupyter Notebook](./NewSaltMaster-SystemsMigration.ipynb) provided to automate system approval. This notebook will add systems to the workspace they were previously a member of. The user who runs the notebook must have the **Add systems** privilege in all the necessary workspaces.

1. Ensure all systems are in the disconnected state and they appear in the pending systems list.
1. Upload **NewSaltMaster-SystemsMigration.ipynb** notebook to JupyterHub.
1. Identify a single system to validate this operation of this notebook.
1. Override `managed_systems_to_approve` with it's id and workspace. The notebook already
1. Ensure all systems are disconnected and appear in the pending systems list.
1. Upload **NewSaltMaster-SystemsMigration.ipynb** to JupyterHub.
1. Identify a single system to validate the notebook operation.
1. Override `managed_systems_to_approve` with its id and workspace. The notebook already
contains this line, we only need to uncomment it and add the id and workspace:

```python
managed_systems_to_approve = [{"id":"Precision_5570--SN-GPP8WT3--MAC-15-75-5B-DC-5F-BB","workspace":"846e294a-a007-47ac-9fc2-fac07eab240a"}]
```

1. Run the notebook - check the output, it should say that 1 system was approved.
1. Run the notebook and check the output. It should say that one system was approved.

```python
Approving 1 batches of 50 systems
Expand All @@ -44,7 +44,7 @@ contains this line, we only need to uncomment it and add the id and workspace:

1. Validate that the selected system is now connected (green).

**Note** Misconfiguration of the RSA keys for the salt master can lead to this operation failing. Review the new secrets and [logs on the system](https://knowledge.ni.com/KnowledgeArticleDetails?id=kA00Z000000kGcSSAU&l=en-US)
**Note** Misconfiguration of the RSA keys for the salt master may cause this operation to fail. Review the new secrets and [logs on the system](https://knowledge.ni.com/KnowledgeArticleDetails?id=kA00Z000000kGcSSAU&l=en-US)
1. After connecting this single system, you can now uncomment the override of `managed_systems_to_approve` and run the notebook again.

```python
Expand Down

0 comments on commit a37ca3d

Please sign in to comment.