-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for migrating systems for the 2023-07 release #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release is coming with a breaking change. All the connected client systems will be disconnected after the upgrade because we've switched to the new salt-master implementation. We are not providing an automated migration process within the product, we are providing manual steps. Signed-off-by: Cristian Hotea <cristian.hotea@ni.com>
chotea
requested review from
JD-Robertson,
prestwick,
BKnight760,
lnowotny,
Christian-Nunnally and
MelissaHilliard
as code owners
June 20, 2023 14:31
chotea
changed the title
Add documentation for migrating systems
Add documentation for migrating systems for the 2023-07 release
Jun 20, 2023
prestwick
requested changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just wording with a few suggestions in the mix.
chotea
commented
Jun 26, 2023
Signed-off-by: Cristian Hotea <cristian.hotea@ni.com>
Co-authored-by: Melissa Hilliard <63749096+MelissaHilliard@users.noreply.github.com>
Co-authored-by: Melissa Hilliard <63749096+MelissaHilliard@users.noreply.github.com>
Co-authored-by: Melissa Hilliard <63749096+MelissaHilliard@users.noreply.github.com>
Co-authored-by: Melissa Hilliard <63749096+MelissaHilliard@users.noreply.github.com>
Signed-off-by: Cristian Hotea <cristian.hotea@ni.com>
chotea
force-pushed
the
users/chotea/DocumentSystemsMigration
branch
from
June 30, 2023 12:14
cafdf98
to
b8564a4
Compare
MelissaHilliard
approved these changes
Jun 30, 2023
prestwick
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
What does this Pull Request accomplish?
This release is coming with a breaking change. All the connected client systems will be disconnected after the upgrade because we've switched to the new salt-master implementation. We are not providing an automated migration process within the product, we are providing manual steps.
I've also created a PR for the ni.com public documentation-> https://ni.visualstudio.com/DefaultCollection/Users/_git/Documentation%20Reviews/pullrequest/510237
Why should this Pull Request be merged?
We need to document the migration process in an accessible location for the Customer Success team.
What testing has been done?
The migration steps have been executed with success against dev/test/rancher.