Add node selector for nbexecservice argo workflows #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure notebook execution pods are scheduled on the labeled node.
BKnight760
requested review from
JD-Robertson,
prestwick,
lnowotny,
Christian-Nunnally and
MelissaHilliard
as code owners
CiprianAnton
approved these changes
Oct 1, 2024
JD-Robertson
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure notebook execution pods are scheduled on the labeled node.
What does this Pull Request accomplish?
Corrects a missing node selector for notebook executions using argo workflows.
Why should this Pull Request be merged?
This ensures that notebook workloads are scheduled on the correctly labeled node.
What testing has been done?
Visual inspection of helm charts.