Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub scripting libraries for duplicated code #109

Open
mdcerna opened this issue Oct 9, 2019 · 0 comments
Open

Scrub scripting libraries for duplicated code #109

mdcerna opened this issue Oct 9, 2019 · 0 comments
Labels
tech debt

Comments

@mdcerna
Copy link
Contributor

mdcerna commented Oct 9, 2019

Is your feature request related to a problem? Please describe.
We have identical VIs (Validate Reference by GUID.vi and Validate Reference by Name.vi) checked into both SLSC Switch, and Routing and Faulting scripting.

Describe the solution you'd like
We should single source this code (and other common code) for the scripting libraries.

Describe alternatives you've considered
Leaving as is means we have to replicate all improvements or bug fixes in both VIs. This makes the code difficult to maintain correctly - changes in one place will not automatically be replicated correctly in the copy.

Additional context
Routing and Faulting project:
image

SLSC Swich project:
image
@mdcerna mdcerna added enhancement New feature or request tech debt and removed enhancement New feature or request labels Oct 9, 2019
@mdcerna mdcerna mentioned this issue Oct 9, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdcerna