feat: implement metricFindQuery #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ni/systemlink-grafana-plugins into users/grchoi/systems-datasource
…ni/systemlink-grafana-plugins into users/grchoi/systems-datasource
Co-authored-by: Cameron Waterman <cameron.waterman@ni.com>
Co-authored-by: Cameron Waterman <cameron.waterman@ni.com>
…ni/systemlink-grafana-plugins into users/grchoi/systems-datasource
cameronwaterman
approved these changes
Aug 3, 2023
cameronwaterman
requested changes
Aug 3, 2023
mure
reviewed
Aug 8, 2023
mure
approved these changes
Aug 10, 2023
cameronwaterman
approved these changes
Aug 11, 2023
…ni/systemlink-grafana-plugins into users/grchoi/systems-datasource
mure
pushed a commit
that referenced
this pull request
Aug 11, 2023
# [1.8.0](v1.7.0...v1.8.0) (2023-08-11) ### Features * implement metricFindQuery ([#11](#11)) ([a5abed2](a5abed2))
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
When users create a query variable, the dropdown list needs to populate with all the systems the user has access to. The user should also be able to look up a system by typing in the system alias. This PR satisfies this user story.
👩💻 Implementation
The metricFindQuery method was implemented using the /query-systems route. Two projections were made to extract the id and the alias. Additionally, a new VariableQuery interface was created in types.ts.
🧪 Testing
The web dev tools were used to test this change. We checked to see if the query variable populated with all the systems that were present in the response.
✅ Checklist