Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tag): tag current value queries #16

Merged
merged 5 commits into from
Aug 14, 2023
Merged

feat(tag): tag current value queries #16

merged 5 commits into from
Aug 14, 2023

Conversation

mure
Copy link
Collaborator

@mure mure commented Aug 14, 2023

Pull Request

🀨 Rationale

https://dev.azure.com/ni/DevCentral/_workitems/edit/2387070

  • Adds support for retrieving the current value of a tag

πŸ‘©β€πŸ’» Implementation

  • Uses the /query-tags-with-values route so that the query can be workspace agnostic. We return the most recently updated tag that matches the given path.
  • Refactored the query logic into a new method runQuery that sends the request for a single target

πŸ§ͺ Testing

  • Added unit tests for the various query scenarios
  • Created a new fixture for building the input to the query method

βœ… Checklist

@mure mure merged commit 8360234 into main Aug 14, 2023
1 check passed
@mure mure deleted the tag-current-value-wip branch August 14, 2023 17:54
mure pushed a commit that referenced this pull request Aug 14, 2023
# [1.10.0](v1.9.1...v1.10.0) (2023-08-14)

### Features

* **tag:** tag current value queries ([#16](#16)) ([8360234](8360234))
@mure
Copy link
Collaborator Author

mure commented Aug 14, 2023

πŸŽ‰ This PR is included in version 1.10.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@mure mure added the released label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants