feat: implement testDatasource method for systems data source #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ni/systemlink-grafana-plugins into users/grchoi/systems-datasource
…ni/systemlink-grafana-plugins into users/grchoi/systems-datasource
mure
approved these changes
Jul 20, 2023
|
Don't forget to prefix your PR title with
|
ggracechoi
changed the title
mure
pushed a commit
that referenced
this pull request
Jul 21, 2023
# [1.5.0](v1.4.1...v1.5.0) (2023-07-21) ### Features * implement testDatasource method for systems data source ([#4](#4)) ([b5a9726](b5a9726))
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification:
A health check needs to be implemented to see if a response can be retrieved using the provided URL. A valid response would indicate that the configuration is correct.
Implementation:
The testDataSource function was implemented using the /get-systems-summary route. A response containing the status counts indicates a valid response for this check. Additionally, a confirmation message displays upon success.
Testing:
The web dev tools were used to test this change. The response was checked to see if the expected response was returned by the query.