Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tag): support datatype and type properties #48

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

mure
Copy link
Collaborator

@mure mure commented Oct 23, 2023

Pull Request

🀨 Rationale

The tag service had a breaking change that renamed the datatype field to type. We should handle both versions of the tag service to avoid any deployment issues.

πŸ‘©β€πŸ’» Implementation

  • Added a separate interface for the legacy field names
  • Check both type and datatype

πŸ§ͺ Testing

  • Added unit tests for the legacy fields

βœ… Checklist

@mure mure marked this pull request as ready for review October 23, 2023 22:43
@mure mure merged commit 0004773 into main Oct 24, 2023
1 check passed
@mure mure deleted the datatype-rename branch October 24, 2023 17:39
mure pushed a commit that referenced this pull request Oct 24, 2023
## [3.7.4](v3.7.3...v3.7.4) (2023-10-24)

### Bug Fixes

* **tag:** support `datatype` and `type` properties ([#48](#48)) ([0004773](0004773))
@mure
Copy link
Collaborator Author

mure commented Oct 24, 2023

πŸŽ‰ This PR is included in version 3.7.4 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@mure mure added the released label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants