feat: display system status counts #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ni/systemlink-grafana-plugins into users/grchoi/systems-datasource
…ni/systemlink-grafana-plugins into users/grchoi/systems-datasource
|
@mure - The checklist link in the PR description is broken FYI |
Co-authored-by: Cameron Waterman <cameron.waterman@ni.com>
Co-authored-by: Cameron Waterman <cameron.waterman@ni.com>
cameronwaterman
approved these changes
Jul 24, 2023
mure
requested changes
Jul 24, 2023
mure
reviewed
Jul 24, 2023
mure
requested changes
Jul 24, 2023
mure
approved these changes
Jul 25, 2023
mure
pushed a commit
that referenced
this pull request
Jul 26, 2023
# [1.6.0](v1.5.0...v1.6.0) (2023-07-26) ### Features * display system status counts ([#6](#6)) ([285b8b2](285b8b2))
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
The Summary query type needs to display the status counts of the systems (Connected and Disconnected) on a dashboard. This PR satisfies this user story.
👩💻 Implementation
The Connected and Disconnected counts are pulled from the /get-systems-summary route. An InflineFieldRow form and a RadioButtonGroup form were added to create the visual components in the query editor. A new type called SystemSummary was created, and the onQueryTypeChange method and the query method were implemented.
🧪 Testing
The web dev tools were used to test this change. We checked to see if a call was being made when the Summary tab was clicked and that the response matched what was expected.
✅ Checklist