feat(asset): add calibration forecast property only row formatting #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkerezsi
requested review from
CiprianAnton,
mure and
cameronwaterman
as code owners
CiprianAnton
approved these changes
Sep 18, 2024
src/datasources/asset-calibration/AssetCalibrationDataSource.test.ts
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/AssetCalibrationDataSource.ts
Outdated
Show resolved
Hide resolved
mure
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Sorry for missing the first review for the calibration forecast stuff.
Some notes:
We're not configuring the day/week/month fields to be FieldType.Time, so it doesn't work with the time series visualization:
Is this intended?
I also noticed that the Week and Month formatting isn't happening at all:
src/datasources/asset-calibration/AssetCalibrationDataSource.test.ts
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/AssetCalibrationDataSource.ts
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/AssetCalibrationDataSource.ts
Outdated
Show resolved
Hide resolved
+ minor refactoring + addressing comments
mure
approved these changes
Sep 19, 2024
mure
pushed a commit
that referenced
this pull request
Sep 19, 2024
## [3.14.0](v3.13.0...v3.14.0) (2024-09-19) ### Features * **asset:** add calibration forecast property only row formatting ([#68](#68)) ([162d782](162d782))
|
🎉 This PR is included in version 3.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
mure
pushed a commit
that referenced
this pull request
Sep 24, 2024
## [3.14.0](v3.13.0...v3.14.0) (2024-09-24) ### Features * **asset:** add calibration forecast property only row formatting ([#68](#68)) ([162d782](162d782))
|
🎉 This PR is included in version 3.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
mure
deleted the
users/alkerezs/implement-property-based-grouping-fromatting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
When rendering property values , we want to format the data structure so that timecharts can also render property groupings.
Task 2842497: Implement Row view when non-time values only are selected
👩💻 Implementation
🧪 Testing
✅ Checklist