feat(asset): resolve minion id #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MileaRobertStefan
requested review from
CiprianAnton and
kkerezsi
as code owners
|
Please Name the PR the right way : https://github.com/ni/systemlink-grafana-plugins#commit-message-format |
kkerezsi
requested changes
Oct 1, 2024
src/datasources/asset-calibration/AssetCalibrationDataSource.test.ts
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/AssetCalibrationDataSource.ts
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/AssetCalibrationDataSource.ts
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/__snapshots__/AssetCalibrationDataSource.test.ts.snap
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/AssetCalibrationDataSource.test.ts
Outdated
Show resolved
Hide resolved
|
@MileaRobertStefan you can also include a screenshot with the change. |
src/datasources/asset-calibration/AssetCalibrationDataSource.ts
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/AssetCalibrationDataSource.ts
Outdated
Show resolved
Hide resolved
kkerezsi
reviewed
Oct 2, 2024
src/datasources/asset-calibration/AssetCalibrationDataSource.ts
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/AssetCalibrationDataSource.ts
Outdated
Show resolved
Hide resolved
mure
reviewed
Oct 2, 2024
src/datasources/asset-calibration/AssetCalibrationDataSource.ts
Outdated
Show resolved
Hide resolved
mure
approved these changes
Oct 2, 2024
kkerezsi
approved these changes
Oct 3, 2024
MileaRobertStefan
deleted the
users/rmilea/2024/replace_systemid_in_asset_cal
branch
mure
pushed a commit
that referenced
this pull request
Oct 3, 2024
## [3.16.0](v3.15.0...v3.16.0) (2024-10-03) ### Features * **asset:** resolve minion id ([#73](#73)) ([75972dd](75972dd))
|
🎉 This PR is included in version 3.16.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Task Replace SystemID.
👩💻 Implementation
On data source initialization fetch a list of systems.
When a response of type minion ID is processed, check if the minion ID has an alias.
🧪 Testing
Change existing tests.
Handle case where minion ID has an alias.
Handle case where minion ID does not have an alias.
Handle case where minion ID is not found.
✅ Checklist