small bug fix to pass max_treedepth along

nicholasjclark · Nov 29, 2024 · 0a95027 · 0a95027
1 parent 3e88a89
commit 0a95027
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 1 deletion.
diff --git a/R/mvgam.R b/R/mvgam.R
@@ -659,6 +659,7 @@ mvgam = function(formula,
     dots$adapt_delta <- NULL
   } else {
     adapt_delta <- control$adapt_delta
+    if(is.null(adapt_delta)) adapt_delta  <- 0.8
   }
 
   if('max_treedepth' %in% names(dots)){
@@ -667,6 +668,7 @@ mvgam = function(formula,
     dots$max_treedepth <- NULL
   } else {
     max_treedepth <- control$max_treedepth
+    if(is.null(max_treedepth)) max_treedepth  <- 10
   }
 
   # Validate trend_model

diff --git a/src/RcppExports.o b/src/RcppExports.o
diff --git a/src/trend_funs.o b/src/trend_funs.o
diff --git a/tests/testthat/Rplots.pdf b/tests/testthat/Rplots.pdf
diff --git a/tests/testthat/test-mvgam-methods.R b/tests/testthat/test-mvgam-methods.R
@@ -300,7 +300,7 @@ test_that("plot_mvgam_series gives reasonable outputs", {
   # And for mvgam objects
   expect_ggplot(plot_mvgam_series(object = mvgam:::mvgam_example1,
                                     series = 1))
-  expect_no_error(plot(mvgam:::mvgam_example1, type = 'series'))
+  expect_no_error(SW(plot(mvgam:::mvgam_example1, type = 'series')))
 })
 
 test_that("forecast and ensemble have reasonable outputs", {

diff --git a/tests/testthat/test-update.R b/tests/testthat/test-update.R
@@ -6,6 +6,7 @@ test_that("update() working correctly", {
   # Can update trend_model
   mod <- update(mvgam:::mvgam_example1,
                 trend_model = AR(p = 2),
+                control = list(max_treedepth = 11),
                 run_model = FALSE)
   expect_true(inherits(mod, 'mvgam_prefit'))
   expect_true(attr(mod$model_data, 'trend_model') == 'AR2')