Taking care of a case where the task could have been popped after

hasTasks() > 0.
nicktacular · May 12, 2014 · f1cd2ed · f1cd2ed
1 parent e7c27e2
commit f1cd2ed
Showing 1 changed file with 11 additions and 10 deletions.
diff --git a/lib/phlask/Runner.php b/lib/phlask/Runner.php
@@ -205,16 +205,17 @@ public function run()
                 $this->logger->info('Have ' . $this->tasks->count() . ' tasks to start');
 
                 //pop a task, init and run
-                $taskSpec = $this->tasks->popTask();
-                $task = Task::factory($taskSpec, $this->id);
-                $this->runningTasks->attach($task);
-
-                try {
-                    $task->run();
-                    $this->logger->info('Started ' . $task->getTaskSpec()->getName() . '(' . $task->getPid() . ')');
-                } catch (Exception\ExecutionException $e) {
-                    $this->logger->warning($e->getMessage());
-                    $this->runningTasks->detach($task);
+                if ($taskSpec = $this->tasks->popTask()) {
+                    $task = Task::factory($taskSpec, $this->id);
+                    $this->runningTasks->attach($task);
+
+                    try {
+                        $task->run();
+                        $this->logger->info('Started ' . $task->getTaskSpec()->getName() . '(' . $task->getPid() . ')');
+                    } catch (Exception\ExecutionException $e) {
+                        $this->logger->warning($e->getMessage());
+                        $this->runningTasks->detach($task);
+                    }
                 }
             }