Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note mismatch between piano illustration and sounds #9

Closed
jdwilkin4 opened this issue Jan 2, 2024 · 2 comments
Closed

Note mismatch between piano illustration and sounds #9

jdwilkin4 opened this issue Jan 2, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jdwilkin4
Copy link
Collaborator

jdwilkin4 commented Jan 2, 2024

Describe the bug
When I was trying out the app, I clicked on the first note which is depicted as an F but the sound and note named displayed said it was a C. Here are all of the current notes displayed when only clicking on the white keys

Screenshot 2024-01-01 at 10 43 00 PM

It looks like everything would need to be shifted by a 4th so the first sound would be an F4 so it matches the piano illustration.

Screenshot 2024-01-01 at 10 46 45 PM

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://pianoparty.netlify.app/
  2. Click on the first white key
  3. See the result say C4
  4. Compare that first note to F4 from this online virtual piano to hear the difference https://www.musicca.com/piano

Expected behavior
Notes should match with illustration

Screenshots
see screenshots above

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@jdwilkin4 jdwilkin4 added the bug Something isn't working label Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take".

For full info on how to contribute, please check out our contributors guide.

@nickytonline
Copy link
Owner

Fixed by 16eba0f and 19843e2.

@nickytonline nickytonline self-assigned this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants