Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Process, Cluster}Task use single string commands. #11

Open
nicmcd opened this issue Jan 30, 2020 · 0 comments
Open

{Process, Cluster}Task use single string commands. #11

nicmcd opened this issue Jan 30, 2020 · 0 comments
Assignees
Labels

Comments

@nicmcd
Copy link
Owner

nicmcd commented Jan 30, 2020

Subprocess ideally wants to receive subprocess commands as lists of strings:
https://docs.python.org/3/library/subprocess.html#frequently-used-arguments

"Providing a sequence of arguments is generally preferred, as it allows the module to take care of any required escaping and quoting of arguments (e.g. to permit spaces in file names)."

The direction is to change to list of strings. This changes the API of taskrun, but for the better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants