change baseurl to https://learning.oreilly.com

[rongfengliang]

change baseurl to https://learning.oreilly.com the old will cause redirect && auth will fail

[ferege]

hi how can i resolve this ?

[rongfengliang]

@ferege can you check lib/safari/index.js code

this.baseUrl = "https://learning.oreilly.com"; 

is https://www.safaribooksonline.com or https://learning.oreilly.com

https://www.safaribooksonline.com can't works

[ferege]

hi , i am not very familiar with these....
i download the patch in my local machine yes now is https://learning.oreilly.com
shall i continue in ananconda prompt ? i do not know the steps exactly , sorrry but can you help me?

[rongfengliang]

@ferege can you try this https://github.com/rongfengliang/SafariBooks-Downloader.git
and install deps and then install with -g && you can alse use -d view http request info check whether baseUrl is https://learning.oreilly.com

[ferege]

(base) C:\Users\Administrator>node -v
v10.15.3

(base) C:\Users\Administrator>npm -v
6.4.1

(base) C:\Users\Administrator>git clone https://github.com/nicohaenggi/SafariBooks-Downloader.git
Cloning into 'SafariBooks-Downloader'...
remote: Enumerating objects: 170, done.
Receiving objects: 59% (101/170) 0 (delta 0), pack-reused 170 eceiving objects: 41% (70/170)
Receiving objects: 100% (170/170), 80.26 KiB | 595.00 KiB/s, done.
Resolving deltas: 100% (62/62), done.

(base) C:\Users\Administrator>cd SafariBooks-Downloader

(base) C:\Users\Administrator\SafariBooks-Downloader>npm install
added 170 packages from 113 contributors and audited 453 packages in 14.21s
found 0 vulnerabilities

(base) C:\Users\Administrator\SafariBooks-Downloader>npm install -g
C:\Users\Administrator\AppData\Roaming\npm\safaribooks-downloader -> C:\Users\Administrator\AppData\Roaming\npm\node_modules\safaribooks-downloader\index.js

• safaribooks-downloader@1.0.0
  updated 1 package in 1.836s

(base) C:\Users\Administrator\SafariBooks-Downloader>safaribooks-downloader --version
1.0.0

(base) C:\Users\Administrator\SafariBooks-Downloader>SafariBooks-Downloader>safaribooks-downloader -b 9781484224427 -u xxxxxx@xxxx -p xxxxxxxxx -o /Users/George/Desktop/testbook.epub

(base) C:\Users\Administrator\SafariBooks-Downloader>safaribooks-downloader -b 9781484224427 -u xxxxxxxxx -p xxxxxxxx -o /Users/George/Desktop/testbook.epub
[safari-downloader] starting application...
[safari-downloader] StatusCodeError: 302 - undefined

(base) C:\Users\Administrator\SafariBooks-Downloader>

i did these in anaconda prompt .......with no luck

[rongfengliang]

@ferege dont't use https://github.com/nicohaenggi/SafariBooks-Downloader it baseurl is wrong you can change it or use my git repo https://github.com/rongfengliang/SafariBooks-Downloader

[ferege]

(base) C:\Users\Administrator>node -v
v10.15.3

(base) C:\Users\Administrator>npm -v
6.4.1

(base) C:\Users\Administrator>git clone https://github.com/rongfengliang/SafariBooks-Downloader.git
fatal: destination path 'SafariBooks-Downloader' already exists and is not an empty directory.

(base) C:\Users\Administrator>

says SafariBooks-Downloader' already exists

[ferege]

(base) C:\Users\Administrator>node -v
v10.15.3

(base) C:\Users\Administrator>npm -v
6.4.1

(base) C:\Users\Administrator>git clone https://github.com/rongfengliang/SafariBooks-Downloader.git
fatal: destination path 'SafariBooks-Downloader' already exists and is not an empty directory.

(base) C:\Users\Administrator>cd Safaribooks

(base) C:\Users\Administrator\safaribooks>github.com/rongfengliang/SafariBooks-Downloader.git
'github.com' is not recognized as an internal or external command,
operable program or batch file.

(base) C:\Users\Administrator\safaribooks>git clone https://github.com/rongfengliang/SafariBooks-Downloader.git
fatal: destination path 'SafariBooks-Downloader' already exists and is not an empty directory.

(base) C:\Users\Administrator\safaribooks>cd SafariBooks-Downloader

(base) C:\Users\Administrator\safaribooks\SafariBooks-Downloader>git clone https://github.com/rongfengliang/SafariBooks-Downloader.git
Cloning into 'SafariBooks-Downloader'...
remote: Enumerating objects: 175, done.
remote: Total 175 (delta 0), reused 0 (delta 0), pack-reused 175
Receiving objects: 100% (175/175), 81.01 KiB | 685.00 KiB/s, done.
Resolving deltas: 100% (65/65), done.

(base) C:\Users\Administrator\safaribooks\SafariBooks-Downloader>npm install
audited 453 packages in 3.665s
found 0 vulnerabilities

(base) C:\Users\Administrator\safaribooks\SafariBooks-Downloader>npm install -g
C:\Users\Administrator\AppData\Roaming\npm\safaribooks-downloader -> C:\Users\Administrator\AppData\Roaming\npm\node_modules\safaribooks-downloader\index.js

• safaribooks-downloader@1.0.0
  updated 1 package in 1.822s

(base) C:\Users\Administrator\safaribooks\SafariBooks-Downloader>safaribooks-downloader --version
1.0.0

(base) C:\Users\Administrator\safaribooks\SafariBooks-Downloader>safaribooks-downloader -b 9781484224427 -u xxxxxxxxx-p xxxxxxxxx -o /Users/George/Desktop/testbook.epub
[safari-downloader] starting application...
[safari-downloader] StatusCodeError: 302 - undefined

(base) C:\Users\Administrator\safaribooks\SafariBooks-Downloader>

the same error unfortunately....

[rongfengliang]

@ferege uninstall the old one first and try again

[ferege]

Thank you very much problem solved!!!!!