Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:-fixes system imagewith the updated android image #23

Merged
merged 7 commits into from
Mar 6, 2024
Merged

fix:-fixes system imagewith the updated android image #23

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
daa985f
fixes system imagewith the updated android image
Biki-das Feb 24, 2024
1bcf63a
updated test to assert conditionally considering the arch of the OS
Biki-das Feb 24, 2024
c1e2cb0
updated test suit to use ABI util function
Biki-das Feb 25, 2024
37aed83
added colon in import
Biki-das Feb 25, 2024
18dec5c
Update testIndex.js
Biki-das Feb 29, 2024
94128ce
Update testIndex.js
garg3133 Mar 6, 2024
4031e30
Update testIndex.js
garg3133 Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/unit_tests/commands/android/testIndex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ const fs = require('fs');
const mockery = require('mockery');
const path = require('path');
const os = require('os');
import { ABI } from '../../../../src/commands/android/constants';

describe('test showHelp', function() {
beforeEach(() => {
Expand Down Expand Up @@ -1585,7 +1586,7 @@ describe('test setupAndroid', function() {

assert.deepStrictEqual(binariesCheckedForWorking, ['sdkmanager']);
assert.strictEqual(cmdlineToolsDownloaded, true);
assert.deepStrictEqual(packagesInstalled, ['system-images;android-30;google_apis;x86_64', 'emulator']); // emulator updated
assert.deepStrictEqual(packagesInstalled, [`system-images;android-30;google_apis;${ABI}`, 'emulator']); // emulator updated
assert.strictEqual(platformFolderCreated, true);
assert.strictEqual(buildToolsDownloaded, true);
assert.strictEqual(avdChecked, true);
Expand Down Expand Up @@ -1793,7 +1794,7 @@ describe('test setupAndroid', function() {

assert.deepStrictEqual(binariesCheckedForWorking, ['sdkmanager']);
assert.strictEqual(cmdlineToolsDownloaded, false);
assert.deepStrictEqual(packagesToInstall, ['system-images;android-30;google_apis;x86_64', 'emulator']); // emulator updated
assert.deepStrictEqual(packagesToInstall, [`system-images;android-30;google_apis;${ABI}`, 'emulator']); // emulator updated
assert.strictEqual(platformFolderCreated, false);
assert.strictEqual(buildToolsDownloaded, false);
assert.strictEqual(avdChecked, true);
Expand Down Expand Up @@ -1897,7 +1898,7 @@ describe('test setupAndroid', function() {

assert.deepStrictEqual(binariesCheckedForWorking, ['sdkmanager']);
assert.strictEqual(cmdlineToolsDownloaded, false);
assert.deepStrictEqual(packagesToInstall, ['system-images;android-30;google_apis;x86_64', 'emulator']); // emulator updated
assert.deepStrictEqual(packagesToInstall, [`system-images;android-30;google_apis;${ABI}`, 'emulator']); // emulator updated
assert.strictEqual(platformFolderCreated, false);
assert.strictEqual(buildToolsDownloaded, true);
assert.strictEqual(avdChecked, true);
Expand Down
Loading