Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream CI tests failing because of incompatability between pre-commit>=3.6 and Python 3.8 #106

Closed
jonded94 opened this issue Feb 29, 2024 · 1 comment

Comments

@jonded94
Copy link
Contributor

Since this commit (84a5fc4) the CI tests are failing.

This is because pre-commit dropped support for Python 3.8 in pre-commit version 3.6.0.

Why is pre-commit always being updated by dependabot? Since this dependency is a dev/lint dependency only, it does not make sense to me dropping support for Python 3.8 of utidylib but instead lock pre-commit to 3.5.0 for example.

@nijel
Copy link
Owner

nijel commented Mar 5, 2024

I didn't notice the test breakage in #99 and merged that change.

Fixed via #108

@nijel nijel closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants