-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ Added Elastic client test cases (Sourcery refactored) #42
Conversation
doc = { | ||
yield { | ||
"id": row["id"], | ||
"name": row["name"], | ||
"email": row["email"], | ||
"phone": row["phone"], | ||
"address": row["address"] or None, | ||
} | ||
yield doc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function generate_actions
refactored with the following changes:
- Inline variable that is immediately yielded (
inline-immediately-yielded-variable
)
bulk(client=elasticsearch_proc, index=es_index, actions=generate_actions(es_index + ".csv")) | ||
bulk( | ||
client=elasticsearch_proc, | ||
index=es_index, | ||
actions=generate_actions(f"{es_index}.csv"), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function populate_data
refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation
)
test/conftest.py
Outdated
with FileLock(str(fn) + ".lock"): | ||
with FileLock(f"{str(fn)}.lock"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function generate_test_csv
refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation
)
Pull Request #41 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
test/client-test
branch, then run:Help us improve this pull request!