Installation failing on node v5.7.1 / Ubuntu 14.04

[avaly]

Trying to install the latest repository code on Ubuntu 14.04 with node.js v5.7.1 and libtag1-dev 1.2.1, I get the following failure:

npm i .
npm WARN deprecated graceful-fs@3.0.8: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.

> taglib@0.8.1 install /home/htpc/tmp/node-taglib
> node-gyp rebuild

make: Entering directory `/home/foo/tmp/node-taglib/build'
  CXX(target) Release/obj.target/taglib/src/bufferstream.o
In file included from ../src/bufferstream.cc:5:0:
../src/taglib.h:26:43: error: ‘Arguments’ in namespace ‘v8’ does not name a type
 v8::Handle<v8::Value> AsyncReadFile(const v8::Arguments &args);
                                           ^
../src/taglib.h:26:58: error: ISO C++ forbids declaration of ‘args’ with no type [-fpermissive]
 v8::Handle<v8::Value> AsyncReadFile(const v8::Arguments &args);
                                                          ^
../src/taglib.h:46:42: error: ‘Arguments’ in namespace ‘v8’ does not name a type
 v8::Handle<v8::Value> AddResolvers(const v8::Arguments &args);
                                          ^
../src/taglib.h:46:57: error: ISO C++ forbids declaration of ‘args’ with no type [-fpermissive]
 v8::Handle<v8::Value> AddResolvers(const v8::Arguments &args);
                                                         ^
make: *** [Release/obj.target/taglib/src/bufferstream.o] Error 1
make: Leaving directory `/home/foo/tmp/node-taglib/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:100:13)
gyp ERR! stack     at ChildProcess.emit (events.js:185:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Linux 3.13.0-67-generic
gyp ERR! command "/usr/bin/nodejs" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/foo/tmp/node-taglib
gyp ERR! node -v v5.7.1
gyp ERR! node-gyp -v v3.2.1
gyp ERR! not ok

[nikhilm]

It is possible that a v8 upgrade broke things. I can't commit to a solid
timeline for fixing this. Happy to accept PRs though.

On Wed, Mar 9, 2016 at 2:14 AM, Valentin Agachi notifications@github.com
wrote:

Trying to install the latest repository code on Ubuntu 14.04 with node.js
v5.7.1 and libtag1-dev 1.2.1, I get the following failure:

npm i .
npm WARN deprecated graceful-fs@3.0.8: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.

taglib@0.8.1 install /home/htpc/tmp/node-taglib
node-gyp rebuild

make: Entering directory /home/foo/tmp/node-taglib/build' CXX(target) Release/obj.target/taglib/src/bufferstream.o In file included from ../src/bufferstream.cc:5:0: ../src/taglib.h:26:43: error: ‘Arguments’ in namespace ‘v8’ does not name a type v8::Handle<v8::Value> AsyncReadFile(const v8::Arguments &args); ^ ../src/taglib.h:26:58: error: ISO C++ forbids declaration of ‘args’ with no type [-fpermissive] v8::Handle<v8::Value> AsyncReadFile(const v8::Arguments &args); ^ ../src/taglib.h:46:42: error: ‘Arguments’ in namespace ‘v8’ does not name a type v8::Handle<v8::Value> AddResolvers(const v8::Arguments &args); ^ ../src/taglib.h:46:57: error: ISO C++ forbids declaration of ‘args’ with no type [-fpermissive] v8::Handle<v8::Value> AddResolvers(const v8::Arguments &args); ^ make: *** [Release/obj.target/taglib/src/bufferstream.o] Error 1 make: Leaving directory/home/foo/tmp/node-taglib/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack at emitTwo (events.js:100:13)
gyp ERR! stack at ChildProcess.emit (events.js:185:7)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Linux 3.13.0-67-generic
gyp ERR! command "/usr/bin/nodejs" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/foo/tmp/node-taglib
gyp ERR! node -v v5.7.1
gyp ERR! node-gyp -v v3.2.1
gyp ERR! not ok

—
Reply to this email directly or view it on GitHub
#62.

[Vortex375]

I created a fork and rewrote the bindings using nan. Though it might not be 100% perfect yet, I can compile it on node v4.x and 5.x

Check out the "v8-compat" branch in my fork.

[nikhilm]

Thanks, could you submit a PR. That makes it easier to review.

On Tue, Mar 22, 2016 at 1:58 AM, Benjamin Schmitz notifications@github.com
wrote:

I created a fork and rewrote the bindings using nan
https://github.com/nodejs/nan. Though it might not be 100% perfect yet,
I can compile it on node v4.x and 5.x

Check out the "v8-compat" branch in my fork
https://github.com/Vortex375/node-taglib/tree/v8-compat.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#62 (comment)

[Vortex375]

I did. Look here: #63