Skip to content

Commit

Permalink
Merge pull request #18 from titaniumtroop/master
Browse files Browse the repository at this point in the history
Merge v1.0.2 release
  • Loading branch information
titaniumtroop authored Apr 21, 2020
2 parents 7b09db6 + 8777807 commit 1e225c0
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 15 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ Type: Package
Title: Tuning of the Latent Dirichlet Allocation Models Parameters
Description: For this first version only metrics to estimate the best fitting
number of topics are implemented.
Version: 1.0.1
Date: 2020-04-08
Version: 1.0.2
Date: 2020-04-09
Authors@R: c(person("Murzintcev", "Nikita", email = "nikita@lreis.ac.cn",
role = c("aut")),
person("Nathan", "Chaney", role = c("ctb", "cre"),
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# ldatuning 1.0.2
* Fixed bug introduced by return_models option in FindTopicNumbers_plot(#16)

# ldatuning 1.0.1
* Option to return list of trained models (#2)
* Expose scoring algorithms to public namespace (#15, @titaniumtroop)
Expand Down
17 changes: 5 additions & 12 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
## Resubmission
This is a resubmission. In this version:
This is a resubmission of v1.0.2 made at the request of CRAN in order to clear
NOTEs for 0 days since last submission as well as a couple of transient errors on
the CRAN package check results. This version:

* Changed maintainer per request of the original creator
* Changed version number from 1.0.0 to 1.0.1
* Made minor performance improvements
* Fixed a minor bug introduced by a new feature in 1.0.1


## Test environments
Expand All @@ -13,17 +13,10 @@ This is a resubmission. In this version:


## R CMD check results
There were no ERRORs or WARNINGs.

There was 1 NOTE concerning the change in maintainer. I have requested that the
previous maintainer email the CRAN submission team. Her request for me to take
over maintenance is also documented in the Github repository
[nikita-moor/ldatuning](https://github.com/nikita-moor/ldatuning/pull/15) in
connection with pull request #15.
There were no ERRORs, WARNINGs, or NOTEs.


## Downstream dependencies
saotd: 1 Note: found 826 marked UTF-8 strings -- This is not unexpected for a
package that contains datasets for natural language processing.


2 changes: 1 addition & 1 deletion man/FindTopicsNumber.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1e225c0

Please sign in to comment.