From 0d0a1754503f506481d87bac84bf1b5ef81a0580 Mon Sep 17 00:00:00 2001 From: Nathan Chaney Date: Thu, 9 Apr 2020 09:27:04 -0500 Subject: [PATCH 1/2] devtools::release v1.0.2 --- DESCRIPTION | 4 ++-- NEWS.md | 3 +++ cran-comments.md | 17 +++++++++-------- man/FindTopicsNumber.Rd | 2 +- 4 files changed, 15 insertions(+), 11 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 110890d..bd43e38 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -3,8 +3,8 @@ Type: Package Title: Tuning of the Latent Dirichlet Allocation Models Parameters Description: For this first version only metrics to estimate the best fitting number of topics are implemented. -Version: 1.0.1 -Date: 2020-04-08 +Version: 1.0.2 +Date: 2020-04-09 Authors@R: c(person("Murzintcev", "Nikita", email = "nikita@lreis.ac.cn", role = c("aut")), person("Nathan", "Chaney", role = c("ctb", "cre"), diff --git a/NEWS.md b/NEWS.md index 9feb65f..d7f140a 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,6 @@ +# ldatuning 1.0.2 + * Fixed bug introduced by return_models option in FindTopicNumbers_plot(#16) + # ldatuning 1.0.1 * Option to return list of trained models (#2) * Expose scoring algorithms to public namespace (#15, @titaniumtroop) diff --git a/cran-comments.md b/cran-comments.md index 3c90da7..05717bd 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,9 +1,8 @@ ## Resubmission This is a resubmission. In this version: -* Changed maintainer per request of the original creator -* Changed version number from 1.0.0 to 1.0.1 -* Made minor performance improvements +* Fixed a minor bug introduced by a new feature in 1.0.1 +* Changed version number from 1.0.1 to 1.0.2 ## Test environments @@ -15,11 +14,13 @@ This is a resubmission. In this version: ## R CMD check results There were no ERRORs or WARNINGs. -There was 1 NOTE concerning the change in maintainer. I have requested that the -previous maintainer email the CRAN submission team. Her request for me to take -over maintenance is also documented in the Github repository -[nikita-moor/ldatuning](https://github.com/nikita-moor/ldatuning/pull/15) in -connection with pull request #15. +Rhub and win-builder have a note for the days since last update: 0. This is a +fix for a small bug identified after the previous submission yesterday. + +There is a WARN for v1.0.0 of the package on r-patched-osx-x86_64. The warning +appears to be related to an issue with a missing driver in the pandoc +installation. There was no error for this check when v1.0.1 was submitted, and +the vignette causing the error hasn't been changed. ## Downstream dependencies diff --git a/man/FindTopicsNumber.Rd b/man/FindTopicsNumber.Rd index 82260ff..4922d9e 100644 --- a/man/FindTopicsNumber.Rd +++ b/man/FindTopicsNumber.Rd @@ -39,7 +39,7 @@ NA, which triggers auto-detection of number of cores on the local machine.} \item{return_models}{Whether or not to return the model objects of class "\link[topicmodels]{LDA}. Defaults to false. Setting to true requires the tibble package.} -\item{verbose}{If false (default), supress all warnings and additional +\item{verbose}{If false (default), suppress all warnings and additional information.} \item{libpath}{Path to R packages (use only if your R installation can't find From 8777807f8dd2daed855bd72ed1a61d63789dcc7f Mon Sep 17 00:00:00 2001 From: Nathan Chaney Date: Mon, 20 Apr 2020 18:58:46 -0500 Subject: [PATCH 2/2] Update cran-comments.md --- cran-comments.md | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 05717bd..41e0c3d 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,8 +1,9 @@ ## Resubmission -This is a resubmission. In this version: +This is a resubmission of v1.0.2 made at the request of CRAN in order to clear +NOTEs for 0 days since last submission as well as a couple of transient errors on +the CRAN package check results. This version: * Fixed a minor bug introduced by a new feature in 1.0.1 -* Changed version number from 1.0.1 to 1.0.2 ## Test environments @@ -12,19 +13,10 @@ This is a resubmission. In this version: ## R CMD check results -There were no ERRORs or WARNINGs. - -Rhub and win-builder have a note for the days since last update: 0. This is a -fix for a small bug identified after the previous submission yesterday. - -There is a WARN for v1.0.0 of the package on r-patched-osx-x86_64. The warning -appears to be related to an issue with a missing driver in the pandoc -installation. There was no error for this check when v1.0.1 was submitted, and -the vignette causing the error hasn't been changed. +There were no ERRORs, WARNINGs, or NOTEs. ## Downstream dependencies saotd: 1 Note: found 826 marked UTF-8 strings -- This is not unexpected for a package that contains datasets for natural language processing. -