Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Selection::append_selection and Selection::replace_with_selection #26

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

niklak
Copy link
Owner

@niklak niklak commented Nov 5, 2024

  • Fixed Selection::append_selection to work with selections with multiple nodes and selections from another tree.
  • Fixed Selection::replace_with_selection to work with selections with multiple nodes and selections from another tree.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.13%. Comparing base (3b76f4c) to head (92fdcb6).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   82.91%   83.13%   +0.21%     
==========================================
  Files          13       13              
  Lines        1961     1986      +25     
==========================================
+ Hits         1626     1651      +25     
  Misses        335      335              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niklak niklak merged commit 45b44fc into main Nov 5, 2024
8 checks passed
@niklak niklak deleted the fix/selection-replace-selection branch November 5, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant