-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial: How to support object-fit: contain and object-fit: cover #3072
Comments
Thanks a lot, Actually this solved the object-fit problem because i changed directly in the node_modules. |
@Oussama-El-Benney you need to use patch-package with a postinstall script, so the changes are applied every time you (or vercel) does a postinstall |
thanks, i'll try this Edit : it works, Thanks a lot |
every good work, make my code rotate,love from china! |
could we get this merged? |
any chance to merge this? ty |
Hi, I tried to change it like this, but it didn't take effect |
I see that the commit history has been completely erased which is very shady. https://github.com/yorickshan/html2canvas-pro/commits/main/ I strongly recommend anyone to Please do a clean fork with commit history 🙏 |
Thanks @raphaelbadia 🙏🏻 |
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch
html2canvas@1.4.1
for the project I'm working on.I noticed reading other issues (#2541, #2442, #725) that this property was not supported.
Here is the diff that solved my problem:
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: