Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve README #5

Open
2 of 4 tasks
stephlocke opened this issue Oct 8, 2018 · 4 comments
Open
2 of 4 tasks

Improve README #5

stephlocke opened this issue Oct 8, 2018 · 4 comments
Labels
hacktoberfest

Comments

@stephlocke
Copy link
Contributor

stephlocke commented Oct 8, 2018 •
edited
Loading

  • Make partial names URLs to the partials
  • Make list of partials a table
  • Show an example of how to integrate a partial in the usage section
  • Elaborate on git submodule instructions to make it easier for folks new to submodules

Happy to take other suggestions too!
@luckycoder1030 luckycoder1030 mentioned this issue Oct 8, 2018
Merged
stephlocke pushed a commit that referenced this issue Oct 10, 2018
@luckycoder1030 @stephlocke
Move partials to a table (#5)
e1b9b8f 
Moved the partials to a table
@agarwalrounak
Copy link
Contributor

Could you please explain what do you mean by Make partial names URLs to the partials?

@stephlocke
Copy link
Contributor Author

It'd be neat if the use_bootstrap.html was instead like use_bootstrap4.html

i.e. the names end up looking like

[`use_bootstrap4.html`](layouts/partials/use_bootstrap4.html)

@agarwalrounak agarwalrounak mentioned this issue Oct 15, 2018
Merged
stephlocke pushed a commit that referenced this issue Oct 15, 2018
@agarwalrounak @stephlocke
Make partial names URLs to the partials (#10)
c088f6b 
Relates to #5
@agarwalrounak
Copy link
Contributor

I think you should tick the first checkbox.

@stephlocke
Copy link
Contributor Author

Thanks for the bump on it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephlocke @agarwalrounak