-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React & Redux group project - Space Travelers' Hub #32
Conversation
Space Traveler Hub
Missions setup
Mission profile 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required Changes ♻️
Hey @nilab-khwaja @evansnyamekye 👋
Highlights 🥇
✔️ Descriptive PR Title
✔️ Descriptive PR Summary
✔️ Impressive UI
✔️ Good Redux Implementation
Good job on implementing some of the requirements, there are some issues that you still need to work on to go to the next project but you are almost there! 😊
Optional
All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.
Cheers, and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/components/Rockets.jsx
Outdated
const rockets = useSelector((state) => state.rockets.rockets); | ||
const status = useSelector((state) => state.rockets.status); | ||
const error = useSelector((state) => state.rockets.error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Great progress on your project! I noticed some code redundancy, and as a developer, it's essential to avoid repetition. Since all the items originate from the same Redux slice, it would be beneficial to retrieve them all at once, rather than fetching them individually. Please consider making this adjustment:
const { rockets, status, error } = useSelector((state) => state.rockets)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nilab-khwaja & @evansnyamekye,
Status: Approved ✔️
Your project is complete! There is nothing else to say other than... it's time to merge it 🚢
Congratulations! 🎉
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- x
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this task, we worked with the real live data from the SpaceX API.