Fixing forbidden exceptions using incorrectly $errorBag

nilportugues · Jul 4, 2016 · 13fcbcf · 13fcbcf
1 parent e6f4077
commit 13fcbcf
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/src/Server/Actions/CreateResource.php b/src/Server/Actions/CreateResource.php
@@ -78,7 +78,7 @@ protected function getErrorResponse(Exception $e, ErrorBag $errorBag)
     {
         switch (get_class($e)) {
             case ForbiddenException::class:
-                $response = $this->forbidden($errorBag);
+                $response = $this->forbidden($this->errorBag);
                 break;
             case DataException::class:
                 $response = $this->unprocessableEntity($errorBag);

diff --git a/src/Server/Actions/DeleteResource.php b/src/Server/Actions/DeleteResource.php
@@ -66,22 +66,21 @@ public function get($id, $className, callable $findOneCallable, callable $delete
 
             return $this->resourceDeleted();
         } catch (Exception $e) {
-            return $this->getErrorResponse($e, $this->errorBag);
+            return $this->getErrorResponse($e);
         }
     }
 
     /**
      * @param Exception $e
-     * @param ErrorBag  $errorBag
      *
      * @return \Symfony\Component\HttpFoundation\Response
      */
-    protected function getErrorResponse(Exception $e, ErrorBag $errorBag)
+    protected function getErrorResponse(Exception $e)
     {
         switch (get_class($e)) {
             case ForbiddenException::class:
                 $response = $this->forbidden(
-                    new ErrorBag([new Error($e->getTitle(), $e->getMessage())])
+                    new ErrorBag([new Error('Forbidden', $e->getMessage())])
                 );
                 break;
             default:

diff --git a/src/Server/Actions/GetResource.php b/src/Server/Actions/GetResource.php
@@ -104,7 +104,7 @@ protected function getErrorResponse(Exception $e)
     {
         switch (get_class($e)) {
             case ForbiddenException::class:
-                $response = $this->forbidden($errorBag);
+                $response = $this->forbidden($this->errorBag);
                 break;
             case QueryException::class:
                 $response = $this->errorResponse($this->errorBag);

diff --git a/src/Server/Actions/PatchResource.php b/src/Server/Actions/PatchResource.php
@@ -87,7 +87,7 @@ protected function getErrorResponse(Exception $e)
     {
         switch (get_class($e)) {
             case ForbiddenException::class:
-                $response = $this->forbidden($errorBag);
+                $response = $this->forbidden($this->errorBag);
                 break;
             case DataException::class:
                 $response = $this->unprocessableEntity($this->errorBag);

diff --git a/src/Server/Actions/PutResource.php b/src/Server/Actions/PutResource.php
@@ -87,7 +87,7 @@ protected function getErrorResponse(Exception $e)
     {
         switch (get_class($e)) {
             case ForbiddenException::class:
-                $response = $this->forbidden($errorBag);
+                $response = $this->forbidden($this->errorBag);
                 break;
             case DataException::class:
                 $response = $this->unprocessableEntity($this->errorBag);