implements cbuilder #24115
Closed
implements cbuilder #24115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Sep 16, 2024
| if typ.baseClass == nil: | ||
| if lacksMTypeField(typ): | ||
| appcg(m, result, " {$n", []) | ||
| when defined(nimUseCBuilder): |
There was a problem hiding this comment.
NO! Just make it use CBuilder's API. No when statements allowed.
There was a problem hiding this comment.
Yeah, I added that because it wasn't finished. It needs a refactor before using cbuilder. I will push easy changes for tuple first and refactor the code later
There was a problem hiding this comment.
Alright but the idea is that every little step keeps the bootstrapping process until cbuilder starts to do something interesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.