Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#557] Automate Release Pull Request Creation Process #567

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

[#557] Automate Release Pull Request Creation Process #567

wants to merge 5 commits into from

Conversation

markgravity
Copy link
Contributor

@markgravity markgravity commented Nov 5, 2024 •
edited
Loading

What happened 👀

  • Add a new workflow to create a release PR
  • Add a new workflow to create a bump version PR

Insight 📝

n/a

Proof Of Work 📹

Bump Version Release
CleanShot 2024-11-11 at 11 14 18 CleanShot 2024-11-11 at 10 36 40

@markgravity markgravity force-pushed the feature/557-automate-release-pull-request-creation-process branch 12 times, most recently from d8a5e83 to 32de584 Compare November 12, 2024 03:34
@markgravity markgravity force-pushed the feature/557-automate-release-pull-request-creation-process branch 8 times, most recently from 697edab to 2961035 Compare November 13, 2024 09:17
@markgravity markgravity self-assigned this Nov 13, 2024
@markgravity markgravity force-pushed the feature/557-automate-release-pull-request-creation-process branch from 2961035 to 99d94b8 Compare November 13, 2024 09:20
@markgravity markgravity changed the base branch from main to develop November 13, 2024 09:21
@markgravity markgravity marked this pull request as ready for review December 16, 2024 06:53
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Dec 16, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

ducbm051291
ducbm051291 reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@ducbm051291 ducbm051291 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest is good to me as we're using this in SB and JB NA

.github/project_workflows/create_release_pull_request.yml Show resolved Hide resolved
@markgravity markgravity force-pushed the feature/557-automate-release-pull-request-creation-process branch from 0589f9f to 2eb6716 Compare December 17, 2024 07:05
luongvo
luongvo reviewed Dec 24, 2024
View reviewed changes
.github/project_workflows/create_release_pull_request.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markgravity Why don't we leverage our prepared https://github.com/nimblehq/github-actions-workflows/tree/develop/create_release_pull_request workflow to create the release pull request for consistency & easy to maintain like us nimblehq/android-templates#562?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luongvo it seems this action requires a milestone to work, right? But we create this workflow to use on a client project, not for this template 🤔

Please correct me if I'm wrong 🙏

@markgravity markgravity force-pushed the feature/557-automate-release-pull-request-creation-process branch 3 times, most recently from 8cd07d6 to 4e28f29 Compare December 27, 2024 07:46
@markgravity markgravity force-pushed the feature/557-automate-release-pull-request-creation-process branch from 4e28f29 to 4308292 Compare December 27, 2024 07:49
phongvhd93
phongvhd93 reviewed Dec 27, 2024
View reviewed changes
Scripts/Swift/iOSTemplateMaker/Sources/iOSTemplateMaker/SetUpiOSProject.swift
@@ -123,7 +123,7 @@ class SetUpIOSProject {
if minimumVersion.isEmpty {
tryMoveDown()

let defaultVersion = "14.0"
let defaultVersion = "15.0"
Copy link
Contributor

@phongvhd93 phongvhd93 Dec 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go with 16.0; only 3% of the share market for the lower version than 16.0

https://developer.apple.com/support/app-store/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phongvhd93 phongvhd93 phongvhd93 left review comments

@luongvo luongvo luongvo left review comments

@suho suho Awaiting requested review from suho suho is a code owner

@blyscuit blyscuit Awaiting requested review from blyscuit blyscuit is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@nmint8m nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

@Shayokh144 Shayokh144 Awaiting requested review from Shayokh144 Shayokh144 is a code owner

@Thieurom Thieurom Awaiting requested review from Thieurom Thieurom is a code owner

@nkhanh44 nkhanh44 Awaiting requested review from nkhanh44 nkhanh44 is a code owner

@dquangit dquangit Awaiting requested review from dquangit dquangit is a code owner

@roman-nimble roman-nimble Awaiting requested review from roman-nimble roman-nimble is a code owner

@nhgia nhgia Awaiting requested review from nhgia nhgia is a code owner

@phoeniex phoeniex Awaiting requested review from phoeniex phoeniex is a code owner

@kevinhoangpq kevinhoangpq Awaiting requested review from kevinhoangpq kevinhoangpq is a code owner

@ducbm051291 ducbm051291 Awaiting requested review from ducbm051291 ducbm051291 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@markgravity markgravity

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate Release Pull Request Creation Process
4 participants
@markgravity @luongvo @phongvhd93 @ducbm051291