Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#557] Automate Release Pull Request Creation Process #567

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/project_workflows/configs/changelog-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"categories": [
{
"title": "## ✨ Features",
"labels": [
"type: feature"
]
},
{
"title": "## 🐛 Bug fixes",
"labels": [
"type: bug"
]
},
{
"title": "## 🧹 Chores",
"labels": [
"type: chore"
]
},
{
"title": "## Others",
"exclude_labels": [
"type: feature",
"type: bug",
"type: chore",
"type: release"
]
}
],
"max_pull_requests": 200
}
84 changes: 84 additions & 0 deletions .github/project_workflows/create_release_pull_request.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markgravity Why don't we leverage our prepared https://github.com/nimblehq/github-actions-workflows/tree/develop/create_release_pull_request workflow to create the release pull request for consistency & easy to maintain like us nimblehq/android-templates#562?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luongvo it seems this action requires a milestone to work, right? But we create this workflow to use on a client project, not for this template 🤔

Please correct me if I'm wrong 🙏

Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
name: Create Release Pull Request

on:
workflow_dispatch:
inputs:
nextVersion:
description: "Next version (eg. 1.0.0)"
required: true
type: string

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
create_release_pull_request:
name: Create Release Pull Request
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Get release version
run: |
filename=$(find . -maxdepth 1 -name "*.xcodeproj" -exec basename {} .xcodeproj \; | head -n 1)
release_version=$(sed -n 's/.*MARKETING_VERSION *= *\([^;]*\);.*/\1/p' "$filename.xcodeproj/project.pbxproj" | head -n 1 | sed 's/^[^=]*=\s*//' | tr -d ' ')
echo $release_version
echo "RELEASE_VERSION=$release_version" >> "$GITHUB_ENV"

- uses: nimblehq/github-actions-workflows/create_release_pull_request@0.1.10
with:
release_version: ${{ env.RELEASE_VERSION }}
changelog_configuration: ".github/workflows/config/changelog-config.json"
assignee: bot-nimble

create_bump_version_pull_request:
name: Create Bump Version Pull Request
runs-on: macos-latest
timeout-minutes: 30
permissions:
contents: write
pull-requests: write
steps:
- name: Validate Version Input
run: |
if ! [[ "${{ github.event.inputs.nextVersion }}" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo "Error: nextVersion must follow semantic versioning (e.g., 1.2.3)"
exit 1
fi
- name: Create Bump Version branch
markgravity marked this conversation as resolved.
Show resolved Hide resolved
uses: peterjgrainger/action-create-branch@v2.2.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
branch: chore/bump-version-to-${{ github.event.inputs.nextVersion }}

- name: Checkout code
uses: actions/checkout@v4
with:
ref: chore/bump-version-to-${{ github.event.inputs.nextVersion }}

- name: Bump version
run: |
filename=$(find . -maxdepth 1 -name "*.xcodeproj" -exec basename {} .xcodeproj \; | head -n 1)
sed -i "" "s/MARKETING_VERSION = .*/MARKETING_VERSION = ${{ github.event.inputs.nextVersion }};/g" $filename.xcodeproj/project.pbxproj

- name: Set up Git
run: |
git config --global user.name 'Github Actions'
git config --global user.email 'github-actions@users.noreply.github.com'

- name: Commit changes
run: |
git add .
git commit -m "[Chore] Bump version to ${{ github.event.inputs.nextVersion }}"
git push origin HEAD

- name: Create pull request
run: |
echo -e "## What happened 👀\n\nBump version to ${{ github.event.inputs.nextVersion }}" > body
export body=$(cat body) ; gh pr create --draft -B develop -H chore/bump-version-to-${{ github.event.inputs.nextVersion }} -t '[Chore] Bump version to ${{ github.event.inputs.nextVersion }}' -b "$body"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
32 changes: 32 additions & 0 deletions .github/workflows/configs/changelog-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"categories": [
{
"title": "## ✨ Features",
"labels": [
"type: feature"
]
},
{
"title": "## 🐛 Bug fixes",
"labels": [
"type: bug"
]
},
{
"title": "## 🧹 Chores",
"labels": [
"type: chore"
]
},
{
"title": "## Others",
"exclude_labels": [
"type: feature",
"type: bug",
"type: chore",
"type: release"
]
}
],
"max_pull_requests": 200
}
38 changes: 38 additions & 0 deletions .github/workflows/create_release_pull_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Create Release Pull Request

on:
pull_request

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
create_release_pull_request:
name: Create Release Pull Request
runs-on: macOS-latest
permissions:
contents: write
pull-requests: write
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Bundle install
run: bundle install

- name: Start Install Script for SwiftUI Template App
run: swift run --package-path Scripts/Swift/iOSTemplateMaker iOSTemplateMaker make --bundle-id-production co.nimblehq.ios.templates --bundle-id-staging co.nimblehq.ios.templates.staging --project-name TemplateApp --interface SwiftUI

- name: Get release version
run: |
filename=$(find . -maxdepth 1 -name "*.xcodeproj" -exec basename {} .xcodeproj \; | head -n 1)
release_version=$(sed -n 's/.*MARKETING_VERSION *= *\([^;]*\);.*/\1/p' "$filename.xcodeproj/project.pbxproj" | head -n 1 | sed 's/^[^=]*=\s*//' | tr -d ' ')
echo $release_version
echo "RELEASE_VERSION=$release_version" >> "$GITHUB_ENV"

- uses: nimblehq/github-actions-workflows/create_release_pull_request@0.1.10
with:
release_version: ${{ env.RELEASE_VERSION }}
changelog_configuration: ".github/workflows/configs/changelog-config.json"
assignee: bot-nimble
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class SetUpIOSProject {
}

if isCI {
minimumVersion = "14.0"
minimumVersion = "15.0"
}

if bundleIdProduction.isEmpty {
Expand Down Expand Up @@ -123,7 +123,7 @@ class SetUpIOSProject {
if minimumVersion.isEmpty {
tryMoveDown()

let defaultVersion = "14.0"
let defaultVersion = "15.0"
Copy link
Contributor

@phongvhd93 phongvhd93 Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go with 16.0; only 3% of the share market for the lower version than 16.0

https://developer.apple.com/support/app-store/

minimumVersion = ask(
"Which is the iOS minimum version?",
note: "Default: \(defaultVersion)",
Expand Down
Loading