Upgrade Typescript to v5 #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
force-pushed
the
soeren/ts-update
branch
from
b17c2a4
to
514dd05
Compare
Merged
sisou
force-pushed
the
soeren/ts-update
branch
2 times, most recently
from
f275cab
to
d41923b
Compare
onmax
approved these changes
Aug 29, 2024
| this.$fields[index].fillValueFrom(paste); | ||
| const field = this.$fields[index]; | ||
| field.focus(); | ||
| if (paste && 'fillValueFrom' in field) { |
There was a problem hiding this comment.
Suggested change
| if (paste && 'fillValueFrom' in field) { | |
| if (paste && 'fillValueFrom' in field && typeof field.fillValueFrom === 'function') { |
not sure if this is relevant
There was a problem hiding this comment.
I don't think this is necessary.
tsconfig.json
Outdated
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "compilerOptions": { | |||
| /* Basic Options */ | |||
| "target": "ES2015", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */ | |||
| "module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | |||
| "target": "ES2020", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */ | |||
There was a problem hiding this comment.
Suggested change
| "target": "ES2020", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */ | |
| "target": "ES2020", /* Specify ECMAScript target version. */ |
There was a problem hiding this comment.
People can learn what values are valid from the docs so we don't have these comments out of sync ?
| "target": "ES2015", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */ | ||
| "module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | ||
| "target": "ES2020", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */ | ||
| "module": "CommonJS", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ |
There was a problem hiding this comment.
Suggested change
| "module": "CommonJS", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | |
| "module": "CommonJS", /* Specify module code generation. */ |
danimoh
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Cool, thanks for this.
I added my improvements, feel free to have a look.
The change of static properties of classes to actual js statics requires an eslint update, so this will be in a separate PR.
@onmax please also review my changes, if you want.
danimoh
force-pushed
the
soeren/ts-update
branch
from
507a78d
to
96a9737
Compare
|
The force-push is for rebase onto master, with resolved conflicts in the |
danimoh
force-pushed
the
soeren/ts-update
branch
from
96a9737
to
74cad88
Compare
sisou
commented
Sep 6, 2024
sisou
commented
Sep 6, 2024
sisou
commented
Sep 6, 2024
sisou
commented
Sep 6, 2024
…pe clashs Typecheck service worker separately with ts WebWorker lib, and the rest of the Keyguard with ts DOM lib. Previously, both libs were active in all files (even though webworker was referenced only in the ServiceWorker via a triple slash directive, this enables it globally), which by itself is inappropriate, but also causes type clashs between the DOM and the WebWorker types, which previously were silenced by skipping lib checks. Now, with this change, and typescript having been updated to a recent version, checking libs has been enabled again.
Browser support for padEnd is now sufficiently good.
Allow them to be passed as null or undefined everywhere.
danimoh
force-pushed
the
soeren/ts-update
branch
from
74cad88
to
911729a
Compare
This was already the case before updating typescript to the latest v3 version in 35859ed, which temporarily removed that handling as is was not compatible with newer typescript versions. This commit reimplements this behavior in a different fashion.
For readability and easier understanding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4 -> v5 was no changes actually, see the commit history.
This is based on theusdcbranch, so can only be merged after #465 is merged.