Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cohort entity and append cohort to space #3365

Open
tsalo opened this issue Sep 20, 2024 · 0 comments
Open

Remove cohort entity and append cohort to space #3365

tsalo opened this issue Sep 20, 2024 · 0 comments

Comments

@tsalo
Copy link
Collaborator

tsalo commented Sep 20, 2024

What would you like to see added in fMRIPrep?

I think surface and volumetric space both need to be indicated in filenames, as the current convention of using shorthand names for combinations of surface template and volume template (i.e., fsLR standing in for fsLR + MNI152NLin6Asym) doesn't extend well to arbitrary combinations.

In order to indicate both the surface and volume templates, I originally proposed adding cohort, volspace, and volcohort to filenames. However, most folks weren't a fan of that, so we've started going in the direction of using + signs in entities to incorporate multiple values (see bids-standard/bids-specification#1926). The thing is, in cases where one or both of the spaces in a CIFTI file (surface and/or volume) have an associated cohort value, the cohort entity doesn't really work. To use an example from nipreps/niworkflows#881, if you wanted dhcpAsym:cohort-42 as the surface space and MNIInfant:cohort-1 as the volume space, the current approach would have an output like space-dhcpAsym+MNIInfant_cohort-42+1, which isn't very interpretable. Instead, appending the cohort directly to the template name might be clearer: space-dhcpAsym42+MNIInfant1.

Do you have any interest in helping implement the feature?

Yes

Additional information / screenshots

This is related to #3330, #3340, bids-standard/bids-specification#1926, nipreps/niworkflows#881, and nipreps/niworkflows#883.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant