-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Pass sbref files to SyN workflow #3060
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## maint/23.1.x #3060 +/- ##
================================================
- Coverage 49.43% 49.36% -0.07%
================================================
Files 46 46
Lines 3599 3604 +5
================================================
Hits 1779 1779
- Misses 1820 1825 +5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, but feels dirty accessing a "private" attribute - I've opened up nipreps/sdcflows#383
I would like to get away from this structure entirely in 23.2.x by passing around a dict of workflows (or at least |
23.1.4 (August 1, 2023) Patch release in the 23.1.x series. This release prioritizes single-band reference BOLD images during SyN-SDC schemes. Additionally, an indices inconsistency was fixed for CIFTI volumetric data. * FIX: Pass sbref files to SyN workflow (#3060) * FIX: Generate CIFTI volume structure indices in column-major order (nipreps/niworkflows#815)
Changes proposed in this pull request
The improvements to SDC to detect sbref files and prefer them needed to come with passing sbrefs to the SyN workflow.
Fixes #3046.
Documentation that should be reviewed