Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Replace config.execution.fmriprep_dir uses in BIDSURI calls with output_dir parameter #3338

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Jul 30, 2024

Closes #3337.

Changes proposed in this pull request

  • Use output_dir function argument for BIDSURI objects instead of the config.execution.fmriprep_dir field. This will let other preps (e.g., ASLPrep) use these workflow functions without having to mock up fmriprep_dir fields in their config objects.

@effigies
Copy link
Member

Are there any of these in smriprep?

@tsalo
Copy link
Collaborator Author

tsalo commented Jul 30, 2024

Not yet. I think I was planning to add BIDSURIs to smriprep and sdcflows at some point, but I haven't gotten around to it yet.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.03%. Comparing base (ea65196) to head (f8121f0).
Report is 79 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3338   +/-   ##
=======================================
  Coverage   71.03%   71.03%           
=======================================
  Files          56       56           
  Lines        4233     4233           
  Branches      638      638           
=======================================
  Hits         3007     3007           
  Misses       1114     1114           
  Partials      112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit fe7c9ff into nipreps:master Jul 30, 2024
18 checks passed
@tsalo tsalo deleted the use-output-dir branch August 7, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace config.execution.fmriprep_dir uses in BIDSURI calls with output_dir parameter
2 participants