Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention fMRIPost-AROMA in parser documentation #3356

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Aug 28, 2024

Closes #3355.

Changes proposed in this pull request

  • Add description to the deprecated ICA-AROMA argument group in the parser.

@tsalo
Copy link
Collaborator Author

tsalo commented Aug 28, 2024

Here's what it looks like:

image

@effigies
Copy link
Member

What does it look like with fmriprep --help?

@effigies
Copy link
Member

The failures will need some commits from #3353. Don't worry about it for now.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.03%. Comparing base (fe7c9ff) to head (fe75352).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3356      +/-   ##
==========================================
- Coverage   71.03%   68.03%   -3.01%     
==========================================
  Files          56       56              
  Lines        4233     4233              
  Branches      638      638              
==========================================
- Hits         3007     2880     -127     
- Misses       1114     1230     +116     
- Partials      112      123      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Collaborator Author

tsalo commented Aug 28, 2024

Here's what fmriprep --help looks like locally:

image

The failures will need some commits from #3353. Don't worry about it for now.

Awesome!

@effigies
Copy link
Member

LGTM. Let's merge it.

@effigies effigies merged commit 946b71e into nipreps:master Aug 28, 2024
6 of 18 checks passed
@tsalo tsalo deleted the mention-fmripost-aroma branch November 6, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention fMRIPost-AROMA in documentation
2 participants