-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF: Replace most of anat_ribbon_wf with a Python function #363
Conversation
abb4bdc
to
663b136
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next #363 +/- ##
===========================================
- Coverage 54.00% 29.41% -24.60%
===========================================
Files 23 20 -3
Lines 1685 1676 -9
Branches 229 231 +2
===========================================
- Hits 910 493 -417
- Misses 719 1170 +451
+ Partials 56 13 -43
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
663b136
to
751369b
Compare
Noting here that the test passed with the old workflow. |
1e74843
to
4624038
Compare
@mgxd I would appreciate a review of this. The regression test that verifies consistent behavior is the main thing. |
Co-authored-by: Mathias Goncalves <goncalves.mathias@gmail.com>
dunno why cache failed, but this looks good to me |
Got sidetracked and rewrote all of
anat_ribbon_wf
except the creating signed distance volumes in Python. Wrote unit and integration test to verify that we do get the same results before replacing.