Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space-fsaverage to sphere_reg output files #446

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

tsalo
Copy link
Contributor

@tsalo tsalo commented Jul 26, 2024

This stems from nipreps/nibabies#366.

Changes proposed:

  • Add space-fsaverage to the filenames of sphere files registering fsnative to fsaverage.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.47%. Comparing base (c361b3a) to head (babeaca).

Files Patch % Lines
smriprep/workflows/outputs.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #446       +/-   ##
===========================================
+ Coverage   66.45%   78.47%   +12.01%     
===========================================
  Files          30       30               
  Lines        2087     2086        -1     
  Branches      250      250               
===========================================
+ Hits         1387     1637      +250     
+ Misses        699      417      -282     
- Partials        1       32       +31     
Flag Coverage Δ
ds054 45.87% <0.00%> (?)
pytest 67.59% <83.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 366df6e into nipreps:master Jul 26, 2024
17 checks passed
mgxd added a commit that referenced this pull request Aug 1, 2024
0.16.0 (July 31, 2024)

Start of the 0.16.x minor series.

This release decouples much of the hardcoded T1w behavior in favor of T1w/T2w options,
to allow easier integration with tools less reliant on a single anatomical scan.

* ENH: Use genericised "anat" input/output for TemplateDimensions (#443)
* ENH: Remove much of the hardcoded `T1w` fields in favor of `anat` (#433)
* RF: Load package data with acres (#448)
* RF: `space-fsaverage` to `sphere_reg` output files (#446)
* MNT: Unpin libitk 5.3 (ANTs 2.5.3 is built with 5.4) (#445)
* MNT: Clean up doc builds, environment, style checks (#444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants