-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dianne tutorials #734
Add dianne tutorials #734
Conversation
Originally written by Dianne Patterson for the U of A group, these tutorials are generally useful to all heudiconv users. This commit brings those tutorials verbatim and will be edited in subsequent commits. Co-authored-by: Dianne Patterson <dkp@arizona.edu>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
=======================================
Coverage 81.97% 81.97%
=======================================
Files 41 41
Lines 4149 4149
=======================================
Hits 3401 3401
Misses 748 748 ☔ View full report in Codecov by Sentry. |
Looks good to me, other than failing lint/spell. One thing though, I don't think “Heuristic File Reference” makes it any clearer. As per the discussion on Monday, you did mention heuristic is a bit vague. |
I would not abuse "specification" word here: if used explicitly it usually refers to some formalized semantic description (e.g. recipe as amounts of each incredient, not really the cooking instructions per se). Heuristic ATM is Python code to provide desired organization (directories) and names to the files given DICOMs metadata. |
FWIW -- pushed 2 little commits to clarify provenance of the docs. Did Dianne state the license? |
No but Dianne gave me permission to use her materials upstream. |
Goal: make the example dataset minimal (delete extra files) I tried deleting all sequences except DTI_30_DIRs_AP_15, but it failed
|
I guess you removed too much -- that is the code/logic in their heuristic. Check which files they care about there. |
40deea6
to
2c5dfff
Compare
2c5dfff
to
5de5e71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the tutorial still makes some assumptions about user-knowledge of MRIs BIDs, which might be just fine for this project-- I just need someone more familiar to review.
|
||
Reproin Scanner File Names | ||
**************************** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yarikoptic This section needs review from someone who is more familiar with bids/reproin/mri
I'm happy to give back to the community. Attribution is lovely (and makes my bosses happier). |
don't know yet why RTD does not report back on builds, although it does them for PRs e.g. https://readthedocs.org/projects/heudiconv/builds/23301131/ . I have checked oauth permissions on personal and nipy org levels -- all seems good. I found that there were 2 instead of one webhooks for github , removed one and resynced another. Let's see if may be it would emerge back edit: actually for this PR 734 the last one from 2 weeks ago. The most recent one was for #735 from a day ago and there it reported fine. So something must be special about this PR :-/ |
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
NeuroStars.org is a platform similar to StackOverflow but dedicated to neuroinformatics. | ||
|
||
All previous ``heudiconv`` questions are available here: | ||
http://neurostars.org/tags/heudiconv/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good, again independent of the goal of the PR
pushed your suggested license commit to see if that kicks off a build |
docs/reproin.rst
Outdated
|
||
**TODO --- Is this generally useful or should be cut???** | ||
|
||
Here is this phantom dataset displayed in the scanner dot cockpit. The directory structure is defined at the top: *Patterson >> Coben >> Patient* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Says "Here" like there would be an image like those https://github.com/ReproNim/reproin/blob/master/docs/walkthrough-1.md#new-program
anything missing?
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
🚀 PR was released in |
🚀 PR was released in |
This PR adds some tutorials from Dianne Patterson at University of Arizona: https://neuroimaging-core-docs.readthedocs.io/en/latest/index.html (with permission, thanks Dianne!)
I've moved some things around so the left bar didn't get so cluttered.
Remaining TODOs:
install
heudiconv
directly, without container in the tutorials