Skip to content

Commit

Permalink
e2e: Remove file:lineo from logs
Browse files Browse the repository at this point in the history
This info is usually not helpful and harmful by taking spaces needed for
important info in the logs. When logging error we have file:lineno info
in the traceback.

Example log with this change:

    === RUN   TestSuites/Exhaustive/Deploy-cephfs#01/Appset/Enable
    2024-10-30T16:46:14.331+0200	INFO	enter EnableProtection appset-deploy-rbd-busybox
    2024-10-30T16:46:14.331+0200	INFO	enter EnableProtection appset-deploy-cephfs-busybox
    2024-10-30T16:46:16.995+0200	INFO	deployment busybox is ready
    2024-10-30T16:46:16.995+0200	INFO	workload Deploy-rbd is ready
    2024-10-30T16:46:16.995+0200	INFO	disapp-deploy-rbd-busybox is deployed

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
  • Loading branch information
nirs committed Oct 30, 2024
1 parent 1664ba6 commit 866f6ed
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions e2e/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"testing"

"github.com/ramendr/ramen/e2e/util"
uberzap "go.uber.org/zap"
"go.uber.org/zap/zapcore"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
)
Expand All @@ -25,9 +24,6 @@ func TestMain(m *testing.M) {

log := zap.New(zap.UseFlagOptions(&zap.Options{
Development: true,
ZapOpts: []uberzap.Option{
uberzap.AddCaller(),
},
TimeEncoder: zapcore.ISO8601TimeEncoder,
}))

Expand Down

0 comments on commit 866f6ed

Please sign in to comment.