Testing pull request #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of horrible one line json, try to check if the pull request author is a member of the organization[1]. [1] https://michaelheap.com/github-actions-check-permission/ Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
When using CI, we want to use a fresh venv for every build so bad venv
created by one job does not break the next job, or bad change in a PR is
not hidden by good venv created by a previous job.
When using local development, you may want to have venv per ramen source
directory. One case is using git worktree to have multiple ramen trees.
With this change you can create a venv per ramen worktree.
Example usage:
hack/make-venv .venv/ramen
Since this is the expected usage, add this path to gitignore, so using
`git clean dxf` does not remove the directory.
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Create venv inside the ramen checkout directory to have fresh venv for every build. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
We want to use the same environment for each runner. To test different environment, we will have multiple runners. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
After adding a label to the runner at: https://github.com/nirs/ramen/settings/actions/runners/22 We can add the label to the workflow to make it run only on runner using this label. This allows testing PR using multiple workflows in parallel on multiple runners. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Instead of repeating the path to the env file and hard coding the environment name, add env.ENV_FILE and env.ENV_NAME. Also always run from the test directory for consistency when using drenv and ramenctl. This allows using env.ENV_FILE in a simple way. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
It cannot work since it hard-codes the environment name and --name-prefix value[1]. [1] RamenDR#1362 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
force-pushed
the
main
branch
2 times, most recently
from
69c6420
to
cf14731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.