Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csi hostpath driver test #6

Closed
wants to merge 3 commits into from
Closed

Csi hostpath driver test #6

wants to merge 3 commits into from

Conversation

nirs
Copy link
Owner

@nirs nirs commented May 12, 2024

No description provided.

nirs added 3 commits May 13, 2024 00:33
The csi-hostpath-driver and volumesnapshots addons start much slower
with minikube 1.33. Replacing them with rook ceph rbd storage, the
kubevirt environments start up to 1.93 times faster.

Start times before and after this change:

| env          | local before | local after | lab before | lab after |
|--------------|--------------|-------------|------------|-----------|
| rdr-kubevirt |          600 |         475 |        920 |       603 |
| kubevirt     |          270 |         230 |        603 |       312 |

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
It is easier to debug issues with a minimal environment. With
rook-cephfs and the required volumesnapshots minikube addon, the rook
environment is less minimal, but it is still quicker to start compared
with the full regional-dr environment.

Example run:

    $ drenv start envs/rook.yaml
    2024-05-12 21:44:00,426 INFO    [rook] Starting environment
    2024-05-12 21:44:00,483 INFO    [dr1] Starting minikube cluster
    2024-05-12 21:44:00,483 INFO    [dr2] Starting minikube cluster
    2024-05-12 21:44:38,650 INFO    [dr1] Cluster started in 38.17 seconds
    2024-05-12 21:44:39,090 INFO    [dr1/0] Running addons/rook-operator/start
    2024-05-12 21:44:39,090 INFO    [dr1/1] Running addons/csi-addons/start
    2024-05-12 21:44:59,732 INFO    [dr2] Cluster started in 59.25 seconds
    2024-05-12 21:45:00,218 INFO    [dr2/0] Running addons/rook-operator/start
    2024-05-12 21:45:00,218 INFO    [dr2/1] Running addons/csi-addons/start
    2024-05-12 21:45:08,913 INFO    [dr1/1] addons/csi-addons/start completed in 29.82 seconds
    2024-05-12 21:45:13,552 INFO    [dr1/0] addons/rook-operator/start completed in 34.46 seconds
    2024-05-12 21:45:13,552 INFO    [dr1/0] Running addons/rook-cluster/start
    2024-05-12 21:45:30,186 INFO    [dr2/1] addons/csi-addons/start completed in 29.97 seconds
    2024-05-12 21:45:41,444 INFO    [dr2/0] addons/rook-operator/start completed in 41.23 seconds
    2024-05-12 21:45:41,444 INFO    [dr2/0] Running addons/rook-cluster/start
    2024-05-12 21:46:21,806 INFO    [dr1/0] addons/rook-cluster/start completed in 68.25 seconds
    2024-05-12 21:46:21,806 INFO    [dr1/0] Running addons/rook-toolbox/start
    2024-05-12 21:46:25,669 INFO    [dr1/0] addons/rook-toolbox/start completed in 3.86 seconds
    2024-05-12 21:46:25,669 INFO    [dr1/0] Running addons/rook-pool/start
    2024-05-12 21:46:40,768 INFO    [dr1/0] addons/rook-pool/start completed in 15.10 seconds
    2024-05-12 21:46:40,768 INFO    [dr1/0] Running addons/rook-cephfs/start
    2024-05-12 21:47:01,116 INFO    [dr2/0] addons/rook-cluster/start completed in 79.67 seconds
    2024-05-12 21:47:01,116 INFO    [dr2/0] Running addons/rook-toolbox/start
    2024-05-12 21:47:01,689 INFO    [dr1/0] addons/rook-cephfs/start completed in 20.92 seconds
    2024-05-12 21:47:01,689 INFO    [dr1/0] Running addons/rook-cephfs/test
    2024-05-12 21:47:04,421 INFO    [dr2/0] addons/rook-toolbox/start completed in 3.31 seconds
    2024-05-12 21:47:04,421 INFO    [dr2/0] Running addons/rook-pool/start
    2024-05-12 21:47:08,994 INFO    [dr1/0] addons/rook-cephfs/test completed in 7.30 seconds
    2024-05-12 21:47:29,597 INFO    [dr2/0] addons/rook-pool/start completed in 25.18 seconds
    2024-05-12 21:47:29,597 INFO    [dr2/0] Running addons/rook-cephfs/start
    2024-05-12 21:47:44,236 INFO    [dr2/0] addons/rook-cephfs/start completed in 14.64 seconds
    2024-05-12 21:47:44,236 INFO    [dr2/0] Running addons/rook-cephfs/test
    2024-05-12 21:47:51,296 INFO    [dr2/0] addons/rook-cephfs/test completed in 7.06 seconds
    2024-05-12 21:47:51,296 INFO    [rook/0] Running addons/rbd-mirror/start
    2024-05-12 21:48:41,169 INFO    [rook/0] addons/rbd-mirror/start completed in 49.87 seconds
    2024-05-12 21:48:41,169 INFO    [rook/0] Running addons/rbd-mirror/test
    2024-05-12 21:48:52,317 INFO    [rook/0] addons/rbd-mirror/test completed in 11.15 seconds
    2024-05-12 21:48:52,317 INFO    [rook] Environment started in 291.89 seconds

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
We added csi-hostpath-driver as a quick temporary solution until we have
cephfs storage. Now that we have it, we can replace it and enjoy reduced
start time, in particular with minikube 1.33.

To replace csi-hostpath-driver, we have to add cephfs to the volsync
development environment. This is slower locally, but faster in the e2e
lab. For regional-dr, this is always faster, up to 1.82 time faster in
the e2e lab.

The main difference is cluster start time - minikube addons are loaded
before minikube start returns.

Before:

    2024-05-12 23:01:42,844 INFO    [dr2] Cluster started in 433.20 seconds
    2024-05-12 23:02:07,215 INFO    [dr1] Cluster started in 457.57 seconds

After:

    2024-05-12 23:18:13,386 INFO    [hub] Cluster started in 71.87 seconds
    2024-05-12 23:18:46,943 INFO    [dr2] Cluster started in 105.43 seconds

Start time before and after this change:

| env          | local before | local after | lab before | lab after |
|--------------|--------------|-------------|------------|-----------|
| regional-dr  |          636 |         426 |        780 |       427 |
| volsync      |          261 |         352 |        520 |       395 |

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs nirs force-pushed the csi-hostpath-driver-test branch from 029287a to 74ba25d Compare May 12, 2024 21:33
@nirs nirs closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant