Kubevirt minimize #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jacklu <jilu@redhat.com>
Signed-off-by: jacklu <jilu@redhat.com>
Signed-off-by: jacklu <jilu@redhat.com>
Signed-off-by: jacklu <jilu@redhat.com>
Signed-off-by: jacklu <jilu@redhat.com>
Signed-off-by: jacklu <jilu@redhat.com>
Signed-off-by: jacklu <jilu@redhat.com>
Signed-off-by: jacklu <jilu@redhat.com>
Signed-off-by: jacklu <jilu@redhat.com>
Minikube v1.33.1 includes the fixes we added recently for v1.33.0, so we
don't need to setup or clean up anything. We can remove the code and
require users and developer to upgrade to latest version, but it is
nicer to make this transparent and skip the unneeded configuration.
We can remove the special fixes for minikube 1.33.0 later maybe when
1.34 will be released.
Example run with minikube 1.33.1:
$ drenv setup -v
2024-05-18 00:19:54,127 INFO [main] Setting up minikube for drenv
2024-05-18 00:19:54,152 DEBUG [minikube] Using minikube version 1.33.1
2024-05-18 00:19:54,152 DEBUG [minikube] Skipping sysctl configuration
2024-05-18 00:19:54,153 DEBUG [minikube] Skipping systemd-resolved configuration
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
The note is correct but not helpful at this point. Let's drop unnecessary details like we did for docs/user-quick-start.md. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Fixes: RamenDR#1260 Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
This change will start using cache for kustomization resources, so starting the addon can directly use the cached resources. Changes: - drenv fetch can be used to fetch resources anytime. - Starting an addon will first try to fetch resources, then apply the fetched resources. If there is no change, fetch won't do anything, so takes very less time. Fixes: RamenDR#1337 Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
Since we upgraded, the e2e job is failing[1] (due to a bug in the e2e integration, the job does not fail!). Lets try to go back to olm 0.22 since we know it worked before this change[2]. [1] last good build: https://github.com/RamenDR/ramen/actions/runs/9134579476/job/25120395289 [2] first bad build: https://github.com/RamenDR/ramen/actions/runs/9158274985/job/25177239838 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
This is required because we can have two PVCs with the same name when multinamespace support is enabled. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Also, create the rd and rs in the same namespace as the PVC and not VRG. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Now that that we have basic test running, we want to fail the workflow if the tests failed. Without this people assumes code changes are passed the tests. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
kubeObjectsRecoveryStartOrResume() error handling is very confusing - the code tries to avoid duplicating error handling in 2 unrelated code paths (ok=true, ok=false), leading to referencing a nil request when ok is false. We need to refactor this later, for now just skip cleanup if there is nothing to cleanup. Bug: https://bugzilla.redhat.com/2282284 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Consume the latest release instead of the temporary build from my private drenv-addons repo. Update the cache file name to force a cache refresh. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
We want to test with the latest release to find issues early. Updating the cache name to force a refresh. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
We don't need HA in a testing environment. Use single replica for the virt-operator deployment. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
To minimize resource usage in our testing environment. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.