Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubevirt minimize #8

Closed
wants to merge 32 commits into from
Closed

Kubevirt minimize #8

wants to merge 32 commits into from

Commits on May 17, 2024

  1. add subscription workload

    Signed-off-by: jacklu <jilu@redhat.com>
    jacklu authored and ShyamsundarR committed May 17, 2024
    Configuration menu
    Copy the full SHA
    896efdd View commit details
    Browse the repository at this point in the history
  2. update make e2e-rdr script to let rdr-e2e.sh could run directly

    Signed-off-by: jacklu <jilu@redhat.com>
    jacklu authored and ShyamsundarR committed May 17, 2024
    Configuration menu
    Copy the full SHA
    750c8b7 View commit details
    Browse the repository at this point in the history
  3. rename rdr-e2e.sh to e2e-rdr.sh

    Signed-off-by: jacklu <jilu@redhat.com>
    jacklu authored and ShyamsundarR committed May 17, 2024
    Configuration menu
    Copy the full SHA
    9ed3a8c View commit details
    Browse the repository at this point in the history
  4. create channel and wait for subscription is ready

    Signed-off-by: jacklu <jilu@redhat.com>
    jacklu authored and ShyamsundarR committed May 17, 2024
    Configuration menu
    Copy the full SHA
    11b20d1 View commit details
    Browse the repository at this point in the history
  5. adopt the latest e2e.yaml change for e2e workflow

    Signed-off-by: jacklu <jilu@redhat.com>
    jacklu authored and ShyamsundarR committed May 17, 2024
    Configuration menu
    Copy the full SHA
    27273e9 View commit details
    Browse the repository at this point in the history
  6. refactor code based on review comments

    Signed-off-by: jacklu <jilu@redhat.com>
    jacklu authored and ShyamsundarR committed May 17, 2024
    Configuration menu
    Copy the full SHA
    722442b View commit details
    Browse the repository at this point in the history
  7. fix lint issue

    Signed-off-by: jacklu <jilu@redhat.com>
    jacklu authored and ShyamsundarR committed May 17, 2024
    Configuration menu
    Copy the full SHA
    97c6e61 View commit details
    Browse the repository at this point in the history
  8. use viper lib to read config in env and yaml

    Signed-off-by: jacklu <jilu@redhat.com>
    jacklu authored and ShyamsundarR committed May 17, 2024
    Configuration menu
    Copy the full SHA
    54f59d5 View commit details
    Browse the repository at this point in the history
  9. wait DRPC to be deleted

    Signed-off-by: jacklu <jilu@redhat.com>
    jacklu authored and ShyamsundarR committed May 17, 2024
    Configuration menu
    Copy the full SHA
    24b60ac View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Skip unneeded setup based on minikube version

    Minikube v1.33.1 includes the fixes we added recently for v1.33.0, so we
    don't need to setup or clean up anything. We can remove the code and
    require users and developer to upgrade to latest version, but it is
    nicer to make this transparent and skip the unneeded configuration.
    
    We can remove the special fixes for minikube 1.33.0 later maybe when
    1.34 will be released.
    
    Example run with minikube 1.33.1:
    
        $ drenv setup -v
        2024-05-18 00:19:54,127 INFO    [main] Setting up minikube for drenv
        2024-05-18 00:19:54,152 DEBUG   [minikube] Using minikube version 1.33.1
        2024-05-18 00:19:54,152 DEBUG   [minikube] Skipping sysctl configuration
        2024-05-18 00:19:54,153 DEBUG   [minikube] Skipping systemd-resolved configuration
    
    Signed-off-by: Nir Soffer <nsoffer@redhat.com>
    nirs authored and ShyamsundarR committed May 18, 2024
    Configuration menu
    Copy the full SHA
    d981687 View commit details
    Browse the repository at this point in the history
  2. Update minikube tested version to v1.33.1

    Signed-off-by: Nir Soffer <nsoffer@redhat.com>
    nirs authored and ShyamsundarR committed May 18, 2024
    Configuration menu
    Copy the full SHA
    1cf25fb View commit details
    Browse the repository at this point in the history
  3. Remove note about --extra-disk argument

    The note is correct but not helpful at this point. Let's drop
    unnecessary details like we did for docs/user-quick-start.md.
    
    Signed-off-by: Nir Soffer <nsoffer@redhat.com>
    nirs authored and ShyamsundarR committed May 18, 2024
    Configuration menu
    Copy the full SHA
    a56be4d View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Upgrade olm version from v0.22.0 to v0.27.0

    Fixes: RamenDR#1260
    Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
    abhijeet219 authored and nirs committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e2b4d3b View commit details
    Browse the repository at this point in the history
  2. Add single cluster env for olm

    Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
    abhijeet219 authored and nirs committed May 20, 2024
    Configuration menu
    Copy the full SHA
    c159b76 View commit details
    Browse the repository at this point in the history
  3. Use static kustomization for olm

    Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
    abhijeet219 authored and nirs committed May 20, 2024
    Configuration menu
    Copy the full SHA
    08a376b View commit details
    Browse the repository at this point in the history
  4. Cache olm resources

    This change will start using cache for kustomization resources, so
    starting the addon can directly use the cached resources.
    
    Changes:
    - drenv fetch can be used to fetch resources anytime.
    - Starting an addon will first try to fetch resources, then apply the
      fetched resources. If there is no change, fetch won't do anything,
      so takes very less time.
    
    Fixes: RamenDR#1337
    Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
    abhijeet219 authored and nirs committed May 20, 2024
    Configuration menu
    Copy the full SHA
    ec2118a View commit details
    Browse the repository at this point in the history
  5. Downgrade olm back to 0.22

    Since we upgraded, the e2e job is failing[1] (due to a bug in the e2e
    integration, the job does not fail!). Lets try to go back to olm 0.22
    since we know it worked before this change[2].
    
    [1] last good build: https://github.com/RamenDR/ramen/actions/runs/9134579476/job/25120395289
    [2] first bad build: https://github.com/RamenDR/ramen/actions/runs/9158274985/job/25177239838
    
    Signed-off-by: Nir Soffer <nsoffer@redhat.com>
    nirs authored and ShyamsundarR committed May 20, 2024
    Configuration menu
    Copy the full SHA
    463cfcf View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. util: add ProtectedPVCNamespacedName func

    Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
    raghavendra-talur authored and BenamarMk committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b5f8936 View commit details
    Browse the repository at this point in the history
  2. vrg: add adminNamespaceVRG field to vshandler

    Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
    raghavendra-talur authored and BenamarMk committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2226128 View commit details
    Browse the repository at this point in the history
  3. vrg: use FindProtectedPVC and remove findFirstProtectedPVCWithName

    This is required because we can have two PVCs with the same name when
    multinamespace support is enabled.
    
    Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
    raghavendra-talur authored and BenamarMk committed May 21, 2024
    Configuration menu
    Copy the full SHA
    edb3f16 View commit details
    Browse the repository at this point in the history
  4. vrg: send pvcNamespacedName everywhere instead of just name

    Also, create the rd and rs in the same namespace as the PVC and not VRG.
    
    Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
    raghavendra-talur authored and BenamarMk committed May 21, 2024
    Configuration menu
    Copy the full SHA
    055e866 View commit details
    Browse the repository at this point in the history
  5. volsync: skip ownerRef on pvc,RD,RS when in multinamespace mode

    Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
    raghavendra-talur authored and BenamarMk committed May 21, 2024
    Configuration menu
    Copy the full SHA
    edafd9f View commit details
    Browse the repository at this point in the history
  6. volsync: create volsync secret in the pvc ns not vrg

    Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
    raghavendra-talur authored and BenamarMk committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e481c2e View commit details
    Browse the repository at this point in the history
  7. tests: fix tests for NewVSHandler

    Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
    raghavendra-talur authored and BenamarMk committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6057eb1 View commit details
    Browse the repository at this point in the history
  8. tests: fix test for TakePVCOwnership

    Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
    raghavendra-talur authored and BenamarMk committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7d26db3 View commit details
    Browse the repository at this point in the history
  9. tests: make sure protected pvc in test have ns

    Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
    raghavendra-talur authored and BenamarMk committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a5e356f View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Fail e2e workflow if tests failed

    Now that that we have basic test running, we want to fail the workflow
    if the tests failed. Without this  people assumes code changes are
    passed the tests.
    
    Signed-off-by: Nir Soffer <nsoffer@redhat.com>
    nirs authored and ShyamsundarR committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d93ac1f View commit details
    Browse the repository at this point in the history
  2. Don't cleanup nil request

    kubeObjectsRecoveryStartOrResume() error handling is very confusing -
    the code tries to avoid duplicating error handling in 2 unrelated code
    paths (ok=true, ok=false), leading to referencing a nil request when ok
    is false.
    
    We need to refactor this later, for now just skip cleanup if there is
    nothing to cleanup.
    
    Bug: https://bugzilla.redhat.com/2282284
    Signed-off-by: Nir Soffer <nsoffer@redhat.com>
    nirs authored and raghavendra-talur committed May 22, 2024
    Configuration menu
    Copy the full SHA
    691062c View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Upgrade kubevirt to 1.2.1

    Consume the latest release instead of the temporary build from my
    private drenv-addons repo.
    
    Update the cache file name to force a cache refresh.
    
    Signed-off-by: Nir Soffer <nsoffer@redhat.com>
    nirs committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4c943bd View commit details
    Browse the repository at this point in the history
  2. Upgrade CDI to 1.59.0

    We want to test with the latest release to find issues early.
    
    Updating the cache name to force a refresh.
    
    Signed-off-by: Nir Soffer <nsoffer@redhat.com>
    nirs committed May 28, 2024
    Configuration menu
    Copy the full SHA
    78f3c3f View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Use single replica in virt-operator

    We don't need HA in a testing environment. Use single replica for the
    virt-operator deployment.
    
    Signed-off-by: Nir Soffer <nsoffer@redhat.com>
    nirs committed May 29, 2024
    Configuration menu
    Copy the full SHA
    d35ecf0 View commit details
    Browse the repository at this point in the history
  2. Use single replica for virt-controller

    To minimize resource usage in our testing environment.
    
    Signed-off-by: Nir Soffer <nsoffer@redhat.com>
    nirs committed May 29, 2024
    Configuration menu
    Copy the full SHA
    999e108 View commit details
    Browse the repository at this point in the history