Fix:copy link not working on mobile #378
Conversation
There was a problem hiding this comment.
@ShoeheyOt
Thank you for your work! It worked in my environment!
Could you only adjust the points I commented on before moving on to merging?
| @@ -30,23 +30,42 @@ export const InviteMemberDialogContent = ({ | |||
| groupId, | |||
| }: IInviteMemberDialogContentProps) => { | |||
| const [isLinkButtonClicked, setIsLinkButtonClicked] = useState(false); | |||
| const [isHash, setHash] = useState(''); | |||
There was a problem hiding this comment.
You shouldn't use is for a string state.
|
|
||
| const hash = result.value.invitationLinkHash; | ||
| navigator.clipboard.writeText(`${CLIENT_BASE_URL}/groups/join/${hash}`); | ||
| setHash(''); |
There was a problem hiding this comment.
We should probably not set the hash to an empty string. This functionality works without resetting it because it's renewed every time the dialog opens. Since a state change always triggers a component's re-rendering, we should avoid unnecessary state updates.
| */ | ||
| useEffect(() => { | ||
| const getHash = async () => { | ||
| if (isDialogOpen) { |
There was a problem hiding this comment.
if (!isDialogOpen) return;If you write the first if statement like this, you can avoid nested multiple if statements.
| alert('Something went wrong. Please try again'); | ||
| return; | ||
| try { | ||
| return await navigator.clipboard.writeText(`${CLIENT_BASE_URL}/groups/join/${isHash}`); |
There was a problem hiding this comment.
try {
if (!hash) throw new Error('Invitation link hash is not set.');
return await navigator.clipboard.writeText(`${CLIENT_BASE_URL}/groups/join/${isHash}`);
}It would be better to throw an error if the hash is not set, so the execution will go to the catch block instead of becoming successful.
* Feature: Replace OG image (#380) * Fix:copy link not working on mobile (#378) * fix: add await * chore: move the return keyword * fix: put fetch function when the dialog open * chore: reset the hash state when copy button clicked * docs: modify the documentation * chore: typo * fix: update based on given feedback --------- Co-authored-by: Nick Ito <nick.yusuke.ito@gmail.com> --------- Co-authored-by: ShoeheyOt <142355969+ShoeheyOt@users.noreply.github.com>
Changes
putGenerateInvitationLinkHashfunction outside ofhandleLinkCopyReview points
Screen Captures
generateInvitationLinkHash.webm
Assignee Checklist:
Reviewer Checklist: