Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake.lock: Update #682

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

flake.lock: Update #682

wants to merge 1 commit into from
+11 −10

Conversation

GaetanLepage
Copy link
Member

No description provided.

@GaetanLepage
Copy link
Member Author

Fails on darwin:

CMake Error at cmake/FindLpeg.cmake:8 (message):
  lpeg library found at
  /nix/store/wj8l688hkqklq8sc68g0qbmgz147nvvx-luajit-2.1.1713773202-env/lib/lua/5.1/lpeg.so
  but built as a bundle rather than a dylib, please rebuild with
  `-dynamiclib` rather than `-bundle`
Call Stack (most recent call first):
  src/nvim/CMakeLists.txt:33 (find_package)

@KarlEricsson
Copy link

Seems like lpeg needs to be built as a shared library: PR with info
This is the homebrew solution referenced in the commitmessage.

@GaetanLepage
Copy link
Member Author

Seems like lpeg needs to be built as a shared library: PR with info
This is the homebrew solution referenced in the commitmessage.

We are already doing that in nixpkgs.
However, this PR has changed the detection logic, so we have to adapt.

@GaetanLepage
Copy link
Member Author

@willruggiano if you happen to have some time to investigate this, please go on.
Otherwise, I will try to have a look this WE.

hurricanehrndz added a commit to hurricanehrndz/pdenv that referenced this pull request Oct 25, 2024
@hurricanehrndz
fix: Darwin builds due upstream changes
25e71d9 
see:
- nix-community/neovim-nightly-overlay#682
hurricanehrndz added a commit to hurricanehrndz/pdenv that referenced this pull request Oct 25, 2024
@hurricanehrndz
fix: Darwin builds due upstream changes
e63de92 
Although in the configure phase we patched the makefile,
buildLuarocksPackage ignores makefile and uses spec.

see:
- nix-community/neovim-nightly-overlay#682
- NixOS/nixpkgs#229275 (comment)
@GaetanLepage GaetanLepage mentioned this pull request Oct 26, 2024
Open
13 tasks
@GaetanLepage
Copy link
Member Author

I pinned nixpkgs to the branch corresponding to NixOS/nixpkgs#351423 and the CI succeeds.

@GaetanLepage GaetanLepage marked this pull request as draft October 26, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaetanLepage @KarlEricsson