Releasing v3.2.0 #55
Merged
Releasing v3.2.0 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y is added. A patch on `hsynch.c` for supporting the various thread placement policies.
…ad placement policy.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 85.05% 83.80% -1.26%
==========================================
Files 69 69
Lines 2984 3031 +47
==========================================
+ Hits 2538 2540 +2
- Misses 446 491 +45
|
|
|
||
| if (numa_node_of_cpu(0) == numa_node_of_cpu(ncpus / 2)) { // SMT or HyperThreading detected | ||
| uint32_t half_node_size = node_size / 2; | ||
| uint32_t ncpus = numa_num_configured_cpus(); |
There was a problem hiding this comment.
Already defined in line 133
There was a problem hiding this comment.
Cleaned up. Check c3c8c99.
| @@ -191,7 +256,9 @@ inline int32_t synchGetPosixThreadId(void) { | |||
| } | |||
|
|
|||
| inline void synchResched(void) { | |||
| if (__noop_resched) { | |||
| if (__noop_resched && synchGetMachineModel() != INTEL_X86_MACHINE) { | |||
There was a problem hiding this comment.
this check already exists in synchPause, I guess you have it here to save a function call, right?
There was a problem hiding this comment.
Cleaned-up. Check a97eef.
Co-authored-by: Spiros N. Agathos <agathosspiros@tutanota.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release introduces the following changes/improvements:
threadtools.hAPI; some basic NUMA functionality is added.hsynch.cfor supporting the various thread placement policies.synchReschedfor many multicore machines (e.g., AMD, Intel, etc.).synchGetMachineModelfunction in the case of multiple calls.hsynch.cis substantially improved (more than X2 in many cases).