Added JWT support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in beans. Implemented UserDetails interface in the User class. Added the implementation for UserDetailsService interface. Added Role entity. Added RoleRepository. Added roles field to the User entity. Added Liquibase changesets to insert roles into DB and assign roles for users.
…in beans. Implemented UserDetails interface in the User class. Added the implementation for UserDetailsService interface. Added Role entity. Added RoleRepository. Added roles field to the User entity. Added Liquibase changesets to insert roles into DB and assign roles for users.
# Conflicts: # src/main/java/mate/academy/bookstore/model/Role.java # src/main/java/mate/academy/bookstore/repository/role/RoleRepository.java # src/main/java/mate/academy/bookstore/service/impl/UserServiceImpl.java # src/main/resources/db/changelog/changes/03-create-roles-table.yaml # src/main/resources/db/changelog/changes/05-insert-roles-into-database.yaml # src/main/resources/db/changelog/changes/07-assign-admin-user-to-role-admin.yaml
d1sam
suggested changes
May 14, 2024
| String email, | ||
| @NotBlank | ||
| @Size(min = 8, message = "Password must be at least 8 characters long") |
|
|
||
| public record UserLoginRequestDto( | ||
| @NotBlank | ||
There was a problem hiding this comment.
Suggested change
| @Size(min = 8, max = 20) |
src/main/java/mate/academy/bookstore/exception/GlobalExceptionHandler.java
Outdated
Show resolved
Hide resolved
Comment on lines
43
to
47
| String bearerToken = request.getHeader("Authorization"); | ||
| if (bearerToken != null && bearerToken.startsWith("Bearer ")) { | ||
| return bearerToken.substring(7); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
please avoid magic numbers and String literals
…nd auth header strings to constant. Removed redundant AuthenticationException handling in GlobalExceptionHandler. Added max size limits for email and password in UserLoginRequestDto
andrii-hoienko
suggested changes
May 14, 2024
Comment on lines
+60
to
+65
| @Bean | ||
| public AuthenticationManager authenticationManager( | ||
| AuthenticationConfiguration authenticationConfiguration | ||
| ) throws Exception { | ||
| return authenticationConfiguration.getAuthenticationManager(); | ||
| } |
There was a problem hiding this comment.
I added it because Spring can't awtowire AuthenticationManager and app failed to start:
Could not autowire. No beans of 'AuthenticationManager' type found.
| private String getToken(HttpServletRequest request) { | ||
| String bearerToken = request.getHeader(AUTHORIZATION); | ||
| if (bearerToken != null && bearerToken.startsWith(BEARER_PREFIX)) { | ||
| return bearerToken.substring(START_INDEX); |
There was a problem hiding this comment.
Suggested change
| return bearerToken.substring(START_INDEX); | |
| return bearerToken.substring(BEARER_PREFIX.length); |
| @RequiredArgsConstructor | ||
| @Component | ||
| public class JwtAuthenticationFilter extends OncePerRequestFilter { | ||
| private static final int START_INDEX = 7; |
There was a problem hiding this comment.
Suggested change
| private static final int START_INDEX = 7; |
| unique: true |
There was a problem hiding this comment.
Suggested change
| unique: true | |
| unique: true | |
There was a problem hiding this comment.
I believe GitHub doesn't display empty lines at the end because it already exists
vovasalyha
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.