Added Category entity with all related dto, service, mapper and controller. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded mapper for Category. Created DB tables categories and books_categories.
vikkushnir
approved these changes
May 16, 2024
| type: bit | ||
| defaultValueBoolean: false | ||
| constraints: | ||
| nullable: false |
There was a problem hiding this comment.
Suggested change
| nullable: false | |
| nullable: false | |
Comment on lines
16
to
28
| @Service | ||
| public class CategoryServiceImpl implements CategoryService { | ||
| private final CategoryRepository categoryRepository; | ||
| private final CategoryMapper categoryMapper; | ||
|
|
||
| @Autowired | ||
| public CategoryServiceImpl( | ||
| CategoryRepository categoryRepository, | ||
| CategoryMapper categoryMapper | ||
| ) { | ||
| this.categoryRepository = categoryRepository; | ||
| this.categoryMapper = categoryMapper; | ||
| } |
There was a problem hiding this comment.
Suggested change
| @Service | |
| public class CategoryServiceImpl implements CategoryService { | |
| private final CategoryRepository categoryRepository; | |
| private final CategoryMapper categoryMapper; | |
| @Autowired | |
| public CategoryServiceImpl( | |
| CategoryRepository categoryRepository, | |
| CategoryMapper categoryMapper | |
| ) { | |
| this.categoryRepository = categoryRepository; | |
| this.categoryMapper = categoryMapper; | |
| } | |
| @Service | |
| @RequiredArgsConstructor | |
| public class CategoryServiceImpl implements CategoryService { | |
| private final CategoryRepository categoryRepository; | |
| private final CategoryMapper categoryMapper; |
andrii-hoienko
suggested changes
May 16, 2024
| CategoryDto update(Long id, CategoryDto categoryDto); | ||
|
|
||
| void delete(Long id); | ||
|
|
Comment on lines
16
to
28
| @Service | ||
| public class CategoryServiceImpl implements CategoryService { | ||
| private final CategoryRepository categoryRepository; | ||
| private final CategoryMapper categoryMapper; | ||
|
|
||
| @Autowired | ||
| public CategoryServiceImpl( | ||
| CategoryRepository categoryRepository, | ||
| CategoryMapper categoryMapper | ||
| ) { | ||
| this.categoryRepository = categoryRepository; | ||
| this.categoryMapper = categoryMapper; | ||
| } |
|
|
||
| @Override | ||
| public void delete(Long id) { | ||
| categoryRepository.deleteById(id); |
There was a problem hiding this comment.
make check before delete as you did in update
| type: bit | ||
| defaultValueBoolean: false | ||
| constraints: | ||
| nullable: false |
…ed findCategoryByIdOrElseThrow() method at CategoryServiceImpl.
yevheniisynytsia
approved these changes
May 17, 2024
| @@ -38,6 +38,11 @@ protected ResponseEntity<Object> handleMethodRepository(DuplicateIsbnException e | |||
| return getResponseEntity(HttpStatus.BAD_REQUEST, ex.getMessage()); | |||
| } | |||
|
|
|||
| @ExceptionHandler(DuplicateEntityException.class) | |||
| protected ResponseEntity<Object> handleMethodRepository(DuplicateEntityException ex) { | |||
There was a problem hiding this comment.
Suggested change
| protected ResponseEntity<Object> handleMethodRepository(DuplicateEntityException ex) { | |
| protected ResponseEntity<Object> handleDuplicateEntity(DuplicateEntityException ex) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.