Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docker support #15

Merged
merged 6 commits into from
May 27, 2024
Merged

Added Docker support #15

merged 6 commits into from
May 27, 2024

Conversation

nklimovych
Copy link
Owner

  • Added Docker dependency in pom.xml.
  • Added Dockerfile, and docker-compose properties and added .env to gitignore.

Copy link

@vikkushnir vikkushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! Only, better to fix spaces

.gitignore Outdated

### Docker ###
/.env

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/.env
/.env

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not resolved

"spring.datasource.password": "${MYSQL_ROOT_PASSWORD}",
"jwt.secret": "${JWT_SECRET}"
}'
JAVA_TOOL_OPTIONS: "-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
JAVA_TOOL_OPTIONS: "-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005"
JAVA_TOOL_OPTIONS: "-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not resolved

pom.xml Outdated
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-docker-compose</artifactId>
</dependency>
</dependencies>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link

@andrii-hoienko andrii-hoienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

.gitignore Outdated

### Docker ###
/.env

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not resolved

"spring.datasource.password": "${MYSQL_ROOT_PASSWORD}",
"jwt.secret": "${JWT_SECRET}"
}'
JAVA_TOOL_OPTIONS: "-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not resolved

nklimovych and others added 5 commits May 23, 2024 18:21
…er (#14)

* Add Order, OrderItem entities, and Status enum.

* Added repository and dto layers, added mappers for related Order & OrderItem entities.

* Added liquibase change files to create orders and order-items tables in DB. Fixed checkstyle issues.

* Added service and controller layers. Code refactored. Fixed issue in ShoppingCartRepository with findByUser query.

* Resolved issues:
 - Refactored order saving method in OrderServiceImpl.
 - Fixed issues with lazy initialization.
 - Added authorized user in the getOrderItem method in the controller so that any user cannot get another user's data.
 - Added equals & hashcode, and toString in OrderItem entity.
 - Added equals and hashcode to all entities.
 - Resolved issue when anyone can search for any order items.

* Resolved issue with shopping cart: now when an order is placed, the shopping cart is removed. Removed soft delete in ShoppingCart

* Fixed the issue where categories were not being added to saved books.

* Added exclude constraint for EqualsAndHashcode and ToString annotations. 
* Added @CreationTimestamp for orderDate in Order entity.
@nklimovych nklimovych merged commit 639f08c into main May 27, 2024
2 checks passed
@nklimovych nklimovych deleted the docker-impl branch May 27, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants