Add Book and Category testing #16
Conversation
nklimovych
commented
May 29, 2024
•
nklimovych
commented
…tory. - Added test methods for CategoryController, CategoryService, and CategoryRepository.
| (2, 2), | ||
| (3, 2), | ||
| (4, 2), | ||
| (5, 3); |
There was a problem hiding this comment.
I believe there is an issue with GitHub as it does not display an empty line at the end.
| @@ -0,0 +1,3 @@ | |||
| DELETE FROM books_categories; | |||
| DELETE FROM categories; | |||
| DELETE FROM books; | |||
| categoryDto.setName(VALID_CATEGORY_NAME); | ||
| return categoryDto; | ||
| } | ||
| } |
| spring.jpa.database-platform=org.hibernate.dialect.H2Dialect | ||
| spring.datasource.url=jdbc:tc:mysql:8:///book_store | ||
| spring.datasource.username=test | ||
| spring.datasource.password=test | ||
|
|
||
| jwt.expiration=300000 | ||
| jwt.secret=JustAnotherSuperSecretString1234! |
|
|
||
| mockMvc.perform(get(BASE_URL)) | ||
| .andExpect(status().isOk()) | ||
| .andExpect(jsonPath(TITLE_0_EXPRESSION).value(VALID_BOOK_TITLE)); |
There was a problem hiding this comment.
Better to check full response object (check other cases as well)
There was a problem hiding this comment.
I don't understand how I missed that...
| assertEquals(VALID_BOOK_ID_KOBZAR, bookOptional.get().getId()); | ||
| assertEquals(VALID_BOOK_ISBN_KOBZAR, bookOptional.get().getIsbn()); |
There was a problem hiding this comment.
CHeck other methods and classes as well
…ct variables using assertEquals. Organize and format TestConstants.java for better readability
| private static final String ADMIN_ROLE = "ADMIN"; | ||
| private static final String USER_ROLE = "USER"; |
There was a problem hiding this comment.
why don't you use enum values with name() method instead?
There was a problem hiding this comment.
Maybe I did something wrong, but it won't let me do it this way.
| @MockBean | ||
| private BookService bookService; |
There was a problem hiding this comment.
I think our api interation tests should not use mocked services, but rather a real service and a testcontainer DB. Same for the category controller test
|
|
||
| mockMvc.perform(get(BASE_URL)) | ||
| .andExpect(status().isOk()) | ||
| .andExpect(jsonPath(TITLE_0_EXPRESSION).value(VALID_BOOK_TITLE)); |
| import org.springframework.web.context.WebApplicationContext; | ||
|
|
||
| @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) | ||
| public class BookControllerTest { |
There was a problem hiding this comment.
we can add some invalid cases, like non existent book, same for category test and services
| return bookDto; | ||
| } | ||
|
|
||
| private BookDto getBookDto(CreateBookRequestDto dto) { |
There was a problem hiding this comment.
it is not just the getter, it also has some parameter, and it essentially maps something to something
